Issue with period in headings number (RTL languages)

[seloumi]

Consider this example of writing arabic headings with tableofcontents

\documentclass{article}
\usepackage{polyglossia}
\setdefaultlanguage[numerals=maghrib]{arabic}
\newfontfamily\arabicfont[Script=Arabic]{Amiri}

\begin{document}

\tableofcontents

\section{عنوان أول}
\subsection{عنوان فرعي أول}
\subsection{عنوان فرعي ثان}
\section{عنوان ثان}
1.23
\end{document}

Which produce

Numbers with period in headings are reversed, this is due to a code from bidi package which invert nembers containing a period but this is not desirable inside headings numbers.

A solution for this issue is to add \setnonlatin from bidi like this

\documentclass{article}
\usepackage{polyglossia}
\setdefaultlanguage[numerals=maghrib]{arabic}
\newfontfamily\arabicfont[Script=Arabic]{Amiri}

\setnonlatin

\begin{document}

\tableofcontents

\section{عنوان أول}
\subsection{عنوان فرعي أول}
\subsection{عنوان فرعي ثان}
\section{عنوان ثان}
1.23
\end{document}

My request is adding this solution when an RTL language is defined as main language, thanks a lot.

[seloumi]

No reply !!!

[jspitz]

@seloumi can you please try if the following change in gloss-arabic produces the correct result in- and outside headings?

\def\arabicnumber#1{%
  \ifeastern@numerals
    \arabicdigits{\number#1}%
  \else
    \RL{\number#1}%
  \fi}

Just replace the existing \arabicnumber definition with this.

[jspitz]

or even better

\def\arabicnumber#1{%
  \ifeastern@numerals
    \arabicdigits{\number#1}%
  \else
    \@ensure@dir{\number#1}%
  \fi}

[seloumi]

Yes this solve the problem

[jspitz]

Thanks for testing. Fixed.

[seloumi]

@jspitz But for mashriq option of numerals the issue still exists

\documentclass{article}
\usepackage{polyglossia}
\setdefaultlanguage[numerals=mashriq]{arabic}
\newfontfamily\arabicfont[Script=Arabic]{Amiri}

\begin{document}

\tableofcontents

\section{عنوان أول}
\subsection{عنوان فرعي أول}
\subsection{عنوان فرعي ثان}
\section{عنوان ثان}
١.٢٣
\end{document}

[seloumi]

I think the issue can be solved either for maghrib or mashriq form with

\def\arabicnumber#1{%
\ifeastern@numerals
\@ensure@dir{\arabicdigits{\number#1}}%
\else
\@ensure@dir{\number#1}%
\fi}

[jspitz]

OK, done.

[seloumi]

Thanks a lot

[jspitz]

I've reverted the fixes. It turned out \set[non]latin is the way to go.

See bidi-tex/bidi#5

[jspitz]

Re-fixed with \setlatin/\setnonlatin.
@seloumi please test.

[seloumi]

@jspitz This solve the issue but another problem appear with numerals=maghrib numbering of equation still in mashriq form !
There are also warnings of hyphenation from latex-gloss.sty

\documentclass{article}
\usepackage{amsmath}
\usepackage{polyglossia}
\setdefaultlanguage[numerals=maghrib]{arabic}
\newfontfamily\arabicfont[Script=Arabic]{Amiri}

\begin{document}

\tableofcontents

\section{عنوان أول}
\subsection{عنوان فرعي أول}
\subsection{عنوان فرعي ثان}
\section{عنوان ثان}

\begin{equation}
a=\frac{dx}{dt}
\end{equation}

\end{document}

[jspitz]

@jspitz This solve the issue but another problem appear with numerals=maghrib numbering of equation still in mashriq form !

Fixed.

There are also warnings of hyphenation from latex-gloss.sty

Yes, this is known.

[seloumi]

@jspitz with version 1.45 the issue persists for eastern numerals form (numbers for subsection heading still reversed)

\documentclass[12pt]{article}
\usepackage{polyglossia}
\setdefaultlanguage{arabic}
\newfontfamily\arabicfont[Script=Arabic]{Amiri}

\begin{document}

\section{عنوان}
\subsection{عنوان فرعي أول}
\subsection{عنوان فرعي ثاني}

\end{document}

[jspitz]

Should be fixed at 4eb6cf5. Please test.

[bykhov]

Since I have recently updated to 1.46, I have problems in Hebrew text with ordinary numbers when both numbers with period and section numbering reverted. Example follows.

\documentclass[12pt]{article}
\usepackage{polyglossia,bidi}
\setmainlanguage{hebrew}
\setotherlanguage{english}
\setmainfont{David}
\setmonofont{Courier New}
\begin{document}
 בדיקה 1.23
\begin{english}
Test 1.23
\end{english}
\section{א}
\subsection{א}
\subsection{א}
\end{document}

See also bidi-tex/bidi#11

[jspitz]

Thanks, this should be fixed in 4c3eb54

[bykhov]

Thanks, it has fixed English text. However, Hebrew one and section numbering are still reverted.

[jspitz]

And they shouldn't? If so, this needs to be fixed in gloss-hebrew.

[jspitz]

Please try after 038ba03

[jspitz]

Please try after 038ba03

No, this does not work.

[seloumi]

@jspitz I thought the numbering in headings for all RTL languages should be RTL !
Since all numbers need to be LTR in hebrew I think a \setlatin command at the beginning is sufficient to solve the issue.

[jspitz]

@jspitz I thought the numbering in headings for all RTL languages should be RTL !
Since all numbers need to be LTR in hebrew I think a \setlatin command at the beginning is sufficient to solve the issue.

But doesn't this re-introduce issues with Arabic?

[bykhov]

Since all numbers need to be LTR in hebrew I think a \setlatin command at the beginning is sufficient to solve the issue.

Excellent with Hebrew!!!

Unfortunately, I don't know about Arabic.

[seloumi]

\setlatin can't be added in gloss-hebrew?

[jspitz]

\setlatin can't be added in gloss-hebrew?

No, only globally for all RLL languages or not.

[jspitz]

Please try 57b17b3

[seloumi]

Also with \setlatin parentheses for equation numbering in RTL context become inverted (if amsmath package is added).

[jspitz]

\setlatin is semantically wrong for Hebrew, as Hebrew is not an LTR script (and this is how the Latin conditional is defined). The only issue is with numbers, and this is now worked around in gloss-hebrew. The general problem is that the bidi package is very much focused on Arabic script (as opposed to other RTL scripts).

[bykhov]

Please try after 038ba03

Also with \setlatin parentheses for equation numbering in RTL context become inverted.

This is how it works now with equation numbering and \setlatin. It looks exactly how it is supposed to be.

\documentclass[12pt,leqno]{article}

\usepackage{amsmath}
\usepackage{polyglossia,bidi}
\setmainlanguage{hebrew}
\setotherlanguage{english}
\setmainfont{David}
\setmonofont{Courier New}
\setlatin
%fix equation numbering for formulas
\makeatletter
\def\tagform@#1{\maketag@@@{(\ignorespaces#1\unskip)}}
\makeatother
\begin{document}
בדיקה 1.23

\begin{english}
Test 1.23
\end{english}

\section{א}
\subsection{א}
\subsection{א}
משוואה \eqref{eq}
\begin{equation}\label{eq}
A = \sin(x)
\end{equation}
\end{document}

[jspitz]

Can you please try after try after 038ba03 without \setlatin and your formula numbering tweak? It should not be needed

[bykhov]

Can you please try after try after 038ba03 without \setlatin and your formula numbering tweak? It should not be needed

Without \setlatin the problem is with numbering inside Hebrew text and sections.

With \setlatin fixes the problem above and arise the problem with numbering of equations (parenthesis).

Please try 57b17b3

Seem to work perfect without \setlatin.

\documentclass[12pt,leqno]{article}

\usepackage{amsmath}
\usepackage{polyglossia,bidi}
\setmainlanguage{hebrew}
\setotherlanguage{english}
\setmainfont{David}
\setmonofont{Courier New}
\begin{document}
בדיקה 1.23
\begin{english}
Test 1.23
\end{english}
\section{א}
\subsection{א}
\subsection{א}
משוואה \eqref{eq}, 
\eqref{eq1}
\begin{subequations}\label{eq1}
\begin{align}
A &= \cos(x) \label{eq}\\
V &= \cos(x)
\end{align}
\end{subequations}
\appendix
\section{בדיקה}
\subsection{בדיקה}
\end{document}

[jspitz]

It turned out \ensure@LTR was needed with Eastern Arabic numerals rather than \ensure@dir to get the proper direction with LuaTeX (XeTeX is unaffected). This has been fixed for 1.63 for Arabic, Kurdish, Persian, Syriac, and Urdu in the abovementioned two commits.