Improve error message for updater checker rate limit (EssentialsX#4560)

JRoy · web-flow · commit 2d511fec4ff8 · 2021-10-11T20:06:18.000+01:00
Fixes EssentialsX#4556
diff --git a/Essentials/src/main/java/com/earth2me/essentials/updatecheck/UpdateChecker.java b/Essentials/src/main/java/com/earth2me/essentials/updatecheck/UpdateChecker.java
@@ -147,8 +147,8 @@ private RemoteVersion fetchDistance(final String head, final String hash) {
                 // Locally built?
                 return new RemoteVersion(BranchStatus.UNKNOWN);
             }
-            if (connection.getResponseCode() == HttpURLConnection.HTTP_INTERNAL_ERROR) {
-                // Github is down
+            if (connection.getResponseCode() == HttpURLConnection.HTTP_INTERNAL_ERROR || connection.getResponseCode() == HttpURLConnection.HTTP_FORBIDDEN) {
+                // GitHub is down or we hit a local rate limit
                 return new RemoteVersion(BranchStatus.ERROR);
             }
 

Original file line number	Diff line number	Diff line change
`@@ -147,8 +147,8 @@ private RemoteVersion fetchDistance(final String head, final String hash) {`
`147`	`147`	`// Locally built?`
`148`	`148`	`return new RemoteVersion(BranchStatus.UNKNOWN);`
`149`	`149`	`}`
`150`		`- if (connection.getResponseCode() == HttpURLConnection.HTTP_INTERNAL_ERROR) {`
`151`		`- // Github is down`
	`150`	`+ if (connection.getResponseCode() == HttpURLConnection.HTTP_INTERNAL_ERROR \|\| connection.getResponseCode() == HttpURLConnection.HTTP_FORBIDDEN) {`
	`151`	`+ // GitHub is down or we hit a local rate limit`
`152`	`152`	`return new RemoteVersion(BranchStatus.ERROR);`
`153`	`153`	`}`
`154`	`154`