Merge pull request #4465 from ljain112/refgression-pr

fix: revert purchase receipt hook and improve test cases

Author: ljain112

india_compliance/gst_india/overrides/test_transaction.py

@@ -372,18 +372,17 @@ def test_block_tax_changing_address_after_submit(self):
         purchase = supplier (re-synced here, so the supplier change alone flips it)."""
         doc = create_transaction(**self.transaction_details, is_in_state=True)
         doc.reload()
-        doc.load_doc_before_save()
 
         if self.is_sales_doctype:
             doc.customer_address = "_Test Registered Customer-Billing-3"  # Karnataka (29)
             doc.place_of_supply = "29-Karnataka"
         else:
             doc.supplier_address = "_Test Registered Supplier-Billing-3"  # Karnataka (29)
 
-        self.assertRaises(
+        self.assertRaisesRegex(
             frappe.exceptions.ValidationError,
-            sync_address_dependent_fields_on_submit,
-            doc,
+            "Cannot charge CGST/SGST for inter-state supplies",
+            doc.save,
         )
 
     def test_block_pos_change_to_different_state_after_submit(self):
@@ -395,13 +394,12 @@ def test_block_pos_change_to_different_state_after_submit(self):
         if doc.place_of_supply == "27-Maharashtra":
             return
 
-        doc.load_doc_before_save()
         doc.place_of_supply = "27-Maharashtra"
 
-        self.assertRaises(
+        self.assertRaisesRegex(
             frappe.exceptions.ValidationError,
-            sync_address_dependent_fields_on_submit,
-            doc,
+            "Cannot charge CGST/SGST for inter-state supplies",
+            doc.save,
         )
 
     def test_allow_tax_neutral_pos_change_after_submit(self):
@@ -442,13 +440,12 @@ def test_block_gst_category_change_after_submit(self):
             address_field = "supplier_address"
             new_address = "_Test Registered Supplier-Billing-2"
 
-        doc.load_doc_before_save()
         doc.set(address_field, new_address)
 
-        self.assertRaises(
+        self.assertRaisesRegex(
             frappe.exceptions.ValidationError,
-            sync_address_dependent_fields_on_submit,
-            doc,
+            "GST Category cannot be set to",
+            doc.save,
         )
 
     def test_block_address_or_pos_change_when_ewaybill_or_irn_exists(self):
@@ -460,16 +457,15 @@ def test_block_address_or_pos_change_when_ewaybill_or_irn_exists(self):
 
         doc = create_transaction(**self.transaction_details)
         doc.reload()
-        doc.load_doc_before_save()
 
         # fake an e-Waybill / IRN, then a tax-neutral POS edit
         doc.set(ewb_field, "123456789012" if ewb_field == "ewaybill" else "a" * 64)
         doc.place_of_supply = "27-Maharashtra" if doc.place_of_supply != "27-Maharashtra" else "29-Karnataka"
 
-        self.assertRaises(
+        self.assertRaisesRegex(
             frappe.exceptions.ValidationError,
-            sync_address_dependent_fields_on_submit,
-            doc,
+            "Cannot change the Place of Supply or address after the e-Waybill",
+            doc.save,
         )
 
     def test_validate_mandatory_gst_category(self):

india_compliance/hooks.py

@@ -209,6 +209,7 @@
         "validate": "india_compliance.gst_india.overrides.purchase_receipt.validate",
         "before_save": "india_compliance.gst_india.overrides.transaction.update_valuation_rate",
         "before_submit": "india_compliance.gst_india.overrides.transaction.update_valuation_rate",
+        "before_update_after_submit": "india_compliance.gst_india.overrides.transaction.sync_address_dependent_fields_on_submit",
         "before_cancel": "india_compliance.gst_india.utils.e_waybill.before_cancel",
         "after_mapping": "india_compliance.gst_india.overrides.transaction.after_mapping",
     },