revisit Rust API

Author: grtlr

crates/store/re_types/src/any_values.rs

@@ -5,7 +5,7 @@ use nohash_hasher::IntMap;
 use crate::{
     ArchetypeFieldName, ArchetypeName, Component, ComponentDescriptor, SerializedComponentBatch,
 };
-use re_types_core::{try_serialize_field, ComponentName};
+use re_types_core::{try_serialize_field, ComponentName, Loggable};
 
 const DEFAULT_ARCHETYPE_NAME: &str = "rerun.AnyValues";
 const DEFAULT_COMPONENT_NAME: &str = "rerun.component.AnyValue";
@@ -43,14 +43,14 @@ impl AnyValues {
         archetype_field_name: impl Into<ArchetypeFieldName>,
         array: arrow::array::ArrayRef,
     ) -> Self {
-        self.field_with_name(archetype_field_name, DEFAULT_COMPONENT_NAME, array)
+        self.field_with_component_name(archetype_field_name, DEFAULT_COMPONENT_NAME, array)
     }
 
     /// Adds a field of arbitrary data to this archetype.
     ///
     /// In many cases, it might be more convenient to use [`Self::component`] to log an existing Rerun component instead.
     #[inline]
-    pub fn field_with_name(
+    pub fn field_with_component_name(
         mut self,
         archetype_field_name: impl Into<ArchetypeFieldName>,
         component_name: impl Into<ComponentName>,
@@ -78,18 +78,18 @@ impl AnyValues {
         archetype_field_name: impl Into<ArchetypeFieldName>,
         component: impl IntoIterator<Item = impl Into<C>>,
     ) -> Self {
-        self.component_with_name(archetype_field_name, C::name(), component)
+        self.loggable(archetype_field_name, C::name(), component)
     }
 
     /// Adds an existing Rerun [`Component`](crate::Component) to this archetype.
     ///
     /// This method can be used to override the component name.
     #[inline]
-    pub fn component_with_name<C: Component>(
+    pub fn loggable<L: Loggable>(
         mut self,
         archetype_field_name: impl Into<ArchetypeFieldName>,
         component_name: impl Into<ComponentName>,
-        component: impl IntoIterator<Item = impl Into<C>>,
+        component: impl IntoIterator<Item = impl Into<L>>,
     ) -> Self {
         let archetype_field_name = archetype_field_name.into();
         try_serialize_field(
@@ -117,16 +117,12 @@ mod test {
     fn simple() {
         let _ = AnyValues::default()
             .component::<components::Scalar>("confidence", [1.2f64, 3.4, 5.6])
-            .component_with_name::<components::Text>(
-                "homepage",
-                "user.url",
-                vec!["https://www.rerun.io"],
-            )
+            .loggable::<components::Text>("homepage", "user.url", vec!["https://www.rerun.io"])
             .field(
                 "description",
                 Arc::new(arrow::array::StringArray::from(vec!["Bla bla bla…"])),
             )
-            .field_with_name(
+            .field_with_component_name(
                 "repository",
                 "user.git",
                 Arc::new(arrow::array::StringArray::from(vec![

crates/store/re_types_core/src/lib.rs

@@ -147,11 +147,11 @@ macro_rules! static_assert_struct_has_fields {
 /// merely be logged, not returned (except in debug builds, where all errors panic).
 #[doc(hidden)] // public so we can access it from re_types too
 #[allow(clippy::unnecessary_wraps)] // clippy gets confused in debug builds
-pub fn try_serialize_field<C: crate::Component>(
+pub fn try_serialize_field<L: Loggable>(
     descriptor: ComponentDescriptor,
-    instances: impl IntoIterator<Item = impl Into<C>>,
+    instances: impl IntoIterator<Item = impl Into<L>>,
 ) -> Option<SerializedComponentBatch> {
-    let res = C::to_arrow(
+    let res = L::to_arrow(
         instances
             .into_iter()
             .map(|v| std::borrow::Cow::Owned(v.into())),