NuGet package dependency with version defined as msbuild property not getting updated #33318
Replies: 3 comments 5 replies
-
|
Please edit and remove the mentions of dependabot, it's unnecessary to do that in order to request a feature |
Beta Was this translation helpful? Give feedback.
-
|
Done. Is there a published community rules doc that I missed that asks us to avoid mentioning having switched from your competition? I've never heard of such a policy before, and having switched from another tool to Renovate, the most important features for Renovate to add in my estimation are the ones that might drive me back due to missing features that I'm accustomed to. |
Beta Was this translation helpful? Give feedback.
-
|
I felt your original post overdid it. It gives off bad vibes to be posting in an open source project "nice tool you have here but I'll be forced to use your competition if you don't do what I ask". Referencing "the competition" can be helpful if it's done in a "here's how it's been solved before" approach but not when it's an implied threat |
Beta Was this translation helpful? Give feedback.
-
|
I'm sorry it came off that way. It wasn't meant to be a threat at all. I realized while editing my original post that I had made a mistake and mentioned recently switching to Dependabot instead of switching from Dependabot. That probably aggravated the problem. I've corrected that. I only just discovered renovate this past week and have already switched all my active repos to it. It's great. It has features that I've wished Dependabot had for ages and makes them easier to access. |
Beta Was this translation helpful? Give feedback.
-
|
#29420 |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for checking, but no. The Directory.Packages.props<PropertyGroup>
<A>1.2.3</A>
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="PackageName" Version="$(A)" />
</ItemGroup> |
Beta Was this translation helpful? Give feedback.
-
|
If the variable is in the same file then we should be able to support this easily. Would leverage the "sharedVariableName" refactor I had in another PR, to resume in the new year |
Beta Was this translation helpful? Give feedback.
-
|
That sounds great! |
Beta Was this translation helpful? Give feedback.
-
How are you running Renovate?
A Mend.io-hosted app
If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.
No response
Please tell us more about your question or problem
The NuGet package dependency expressed here (and whose referenced msbuild property is defined earlier in the file) is not getting an update PR created by Renovate.
The renovate logs mention most of the other package names that I spot checked, but "PolyType" does not appear at all, leading me to believe that somehow the scanner is missing PolyType as a dependency.
I then checked for "Microsoft.CodeAnalysis.CSharp.Workspaces" in the log and couldn't find that either. This dependency is also based on an msbuild property.
This leads me to believe that Renovate fails whenever the package version isn't a literal number but rather an msbuild property that is set to a version number.
If so, this is a loss for me in functionality since switching to Renovate from (redacted) earlier this week, which notices when groups of package versions are defined by the same property and will issue an update to the property, and then in the PR title it references an update of the property.
Now, if/when Renovate supports this, it could certainly do better than the competition by:
Logs (if relevant)
Logs
{ "deps": [ { "currentValue": "1.2.0.556", "currentVersion": "1.2.0.556", "currentVersionAgeInDays": 373, "currentVersionTimestamp": "2023-12-20T22:00:37.823Z", "datasource": "nuget", "depName": "StyleCop.Analyzers.Unstable", "depType": "nuget", "packageName": "StyleCop.Analyzers.Unstable", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/DotNetAnalyzers/StyleCopAnalyzers", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "1.15.0", "currentVersion": "1.15.0", "currentVersionAgeInDays": 37, "currentVersionTimestamp": "2024-11-21T06:00:18.590Z", "datasource": "nuget", "depName": "PolySharp", "depType": "nuget", "packageName": "PolySharp", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/Sergio0694/PolySharp", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "3.7.112", "currentVersion": "3.7.112", "currentVersionAgeInDays": 16, "currentVersionTimestamp": "2024-12-12T01:50:37.400Z", "datasource": "nuget", "depName": "Nerdbank.GitVersioning", "depType": "nuget", "packageName": "Nerdbank.GitVersioning", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/dotnet/Nerdbank.GitVersioning", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "1.0.0-beta.59", "currentVersion": "1.0.0-beta.59", "currentVersionAgeInDays": 2273, "currentVersionTimestamp": "2018-10-08T13:27:07.220Z", "datasource": "nuget", "depName": "DotNetAnalyzers.DocumentationAnalyzers", "depType": "nuget", "packageName": "DotNetAnalyzers.DocumentationAnalyzers", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/DotNetAnalyzers/DocumentationAnalyzers", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "0.1.593", "currentVersion": "0.1.593", "currentVersionAgeInDays": 172, "currentVersionTimestamp": "2024-07-08T15:19:52.867Z", "datasource": "nuget", "depName": "CSharpIsNullAnalyzer", "depType": "nuget", "packageName": "CSharpIsNullAnalyzer", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/AArnott/CSharpIsNull", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "3.11.0-beta1.24527.2", "currentVersion": "3.11.0-beta1.24527.2", "currentVersionAgeInDays": 17, "currentVersionTimestamp": "2024-12-10T18:57:50.530Z", "datasource": "nuget", "depName": "Microsoft.CodeAnalysis.ResxSourceGenerator", "depType": "nuget", "packageName": "Microsoft.CodeAnalysis.ResxSourceGenerator", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/dotnet/roslyn-analyzers", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "1.0.0", "currentVersion": "1.0.0", "currentVersionAgeInDays": 11, "currentVersionTimestamp": "2024-12-16T19:18:47.953Z", "datasource": "nuget", "depName": "xunit.v3", "depType": "nuget", "packageName": "xunit.v3", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/xunit/xunit", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "3.0.0", "currentVersion": "3.0.0", "currentVersionAgeInDays": 11, "currentVersionTimestamp": "2024-12-16T19:18:47.193Z", "datasource": "nuget", "depName": "xunit.runner.visualstudio", "depType": "nuget", "packageName": "xunit.runner.visualstudio", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/xunit/visualstudio.xunit", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "17.12.0", "currentVersion": "17.12.0", "currentVersionAgeInDays": 39, "currentVersionTimestamp": "2024-11-19T13:25:30.753Z", "datasource": "nuget", "depName": "Microsoft.NET.Test.Sdk", "depType": "nuget", "packageName": "Microsoft.NET.Test.Sdk", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/microsoft/vstest", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "8.0.0", "currentVersion": "8.0.0", "currentVersionAgeInDays": 410, "currentVersionTimestamp": "2023-11-14T13:35:32.167Z", "datasource": "nuget", "depName": "System.Collections.Immutable", "depType": "nuget", "homepage": "https://dot.net/", "packageName": "System.Collections.Immutable", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/dotnet/runtime", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "8.0.5", "currentVersion": "8.0.5", "currentVersionAgeInDays": 81, "currentVersionTimestamp": "2024-10-08T13:32:43.627Z", "datasource": "nuget", "depName": "System.Text.Json", "depType": "nuget", "homepage": "https://dot.net/", "packageName": "System.Text.Json", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/dotnet/runtime", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "8.0.0", "currentVersion": "8.0.0", "currentVersionAgeInDays": 410, "currentVersionTimestamp": "2023-11-14T13:35:32.167Z", "datasource": "nuget", "depName": "System.Collections.Immutable", "depType": "nuget", "homepage": "https://dot.net/", "packageName": "System.Collections.Immutable", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/dotnet/runtime", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "6.0.0", "currentVersion": "6.0.0", "currentVersionAgeInDays": 45, "currentVersionTimestamp": "2024-11-12T23:06:59.327Z", "datasource": "nuget", "depName": "Microsoft.Bcl.HashCode", "depType": "nuget", "packageName": "Microsoft.Bcl.HashCode", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/dotnet/maintenance-packages", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "2.0.5-alpha", "currentVersion": "2.0.5-alpha", "currentVersionAgeInDays": 5, "currentVersionTimestamp": "2024-12-23T14:45:26.347Z", "datasource": "nuget", "depName": "Xunit.Combinatorial", "depType": "nuget", "homepage": "https://github.com/aarnott/Xunit.Combinatorial", "packageName": "Xunit.Combinatorial", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/AArnott/Xunit.Combinatorial", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "9.0.0", "currentVersion": "9.0.0", "currentVersionAgeInDays": 45, "currentVersionTimestamp": "2024-11-12T18:29:27.500Z", "datasource": "nuget", "depName": "System.IO.Pipelines", "depType": "nuget", "homepage": "https://dot.net/", "packageName": "System.IO.Pipelines", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/dotnet/runtime", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "4.0.1", "currentVersion": "4.0.1", "currentVersionAgeInDays": 203, "currentVersionTimestamp": "2024-06-08T13:10:37.150Z", "datasource": "nuget", "depName": "Newtonsoft.Json.Schema", "depType": "nuget", "homepage": "https://www.newtonsoft.com/jsonschema", "packageName": "Newtonsoft.Json.Schema", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/JamesNK/Newtonsoft.Json.Schema", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "2.11.79", "currentVersion": "2.11.79", "currentVersionAgeInDays": 126, "currentVersionTimestamp": "2024-08-23T23:48:23.407Z", "datasource": "nuget", "depName": "Nerdbank.Streams", "depType": "nuget", "packageName": "Nerdbank.Streams", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/AArnott/Nerdbank.Streams", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "17.8.8", "currentVersion": "17.8.8", "currentVersionAgeInDays": 409, "currentVersionTimestamp": "2023-11-14T19:51:59.267Z", "datasource": "nuget", "depName": "Microsoft.VisualStudio.Validation", "depType": "nuget", "homepage": "https://github.com/Microsoft/vs-validation", "packageName": "Microsoft.VisualStudio.Validation", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/microsoft/vs-validation", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "17.12.19", "currentVersion": "17.12.19", "currentVersionAgeInDays": 45, "currentVersionTimestamp": "2024-11-12T22:34:54.853Z", "datasource": "nuget", "depName": "Microsoft.VisualStudio.Threading.Analyzers", "depType": "nuget", "homepage": "https://github.com/Microsoft/vs-threading", "packageName": "Microsoft.VisualStudio.Threading.Analyzers", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/microsoft/vs-threading", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "17.12.6", "currentVersion": "17.12.6", "currentVersionAgeInDays": 59, "currentVersionTimestamp": "2024-10-30T13:50:28.930Z", "datasource": "nuget", "depName": "Microsoft.NET.StringTools", "depType": "nuget", "homepage": "http://go.microsoft.com/fwlink/?LinkId=624683", "packageName": "Microsoft.NET.StringTools", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/dotnet/msbuild", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "3.3.4", "currentVersion": "3.3.4", "currentVersionAgeInDays": 710, "currentVersionTimestamp": "2023-01-18T07:15:07.717Z", "datasource": "nuget", "depName": "Microsoft.CodeAnalysis.PublicApiAnalyzers", "depType": "nuget", "packageName": "Microsoft.CodeAnalysis.PublicApiAnalyzers", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/dotnet/roslyn-analyzers", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "1.1.2", "currentVersion": "1.1.2", "currentVersionAgeInDays": 191, "currentVersionTimestamp": "2024-06-19T18:33:25.140Z", "datasource": "nuget", "depName": "Microsoft.CodeAnalysis.CSharp.CodeFix.Testing.XUnit", "depType": "nuget", "packageName": "Microsoft.CodeAnalysis.CSharp.CodeFix.Testing.XUnit", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/dotnet/roslyn-sdk", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "3.1.1", "currentVersion": "3.1.1", "currentVersionAgeInDays": 2, "currentVersionTimestamp": "2024-12-26T09:12:06.690Z", "datasource": "nuget", "depName": "MessagePack", "depType": "nuget", "packageName": "MessagePack", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/MessagePack-CSharp/MessagePack-CSharp", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "1.7.2", "currentVersion": "1.7.2", "currentVersionAgeInDays": 382, "currentVersionTimestamp": "2023-12-11T16:53:35.640Z", "datasource": "nuget", "depName": "DiffPlex", "depType": "nuget", "packageName": "DiffPlex", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/mmanela/diffplex", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "0.14.0", "currentVersion": "0.14.0", "currentVersionAgeInDays": 144, "currentVersionTimestamp": "2024-08-06T14:45:04.417Z", "datasource": "nuget", "depName": "BenchmarkDotNet.Diagnostics.Windows", "depType": "nuget", "packageName": "BenchmarkDotNet.Diagnostics.Windows", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/dotnet/BenchmarkDotNet", "versioning": "nuget", "warnings": [], "updates": [] }, { "currentValue": "0.14.0", "currentVersion": "0.14.0", "currentVersionAgeInDays": 144, "currentVersionTimestamp": "2024-08-06T14:44:58.453Z", "datasource": "nuget", "depName": "BenchmarkDotNet", "depType": "nuget", "packageName": "BenchmarkDotNet", "registryUrl": "https://api.nuget.org/v3/index.json", "registryUrls": [ "https://api.nuget.org/v3/index.json" ], "sourceUrl": "https://github.com/dotnet/BenchmarkDotNet", "versioning": "nuget", "warnings": [], "updates": [] } ], "packageFile": "Directory.Packages.props" },Beta Was this translation helpful? Give feedback.
All reactions