Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning about unsupported fetch options #2015

Closed
Aprillion opened this issue Feb 17, 2022 · 5 comments
Closed

Warning about unsupported fetch options #2015

Aprillion opened this issue Feb 17, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@Aprillion
Copy link
Contributor

What version of Remix are you using?

1.2.1

Steps to Reproduce

Expected Behavior

Some warning about unsupported fetch options, e.g.:

  • a type check if possible
  • fail in the same way in local dev server as it fails after deployment
  • maybe a chapter in documentation about all the differences of non-native fetch from server?

Additionally, if some server environments (will) support native-like HTTP Cache, it would be nice to be able to debug server side fetch requests (similar to browser Network tab) => any documented advice how to debug server fetch would be appreciated too.

Actual Behavior

Everything worked fine locally, then I got an error after deployment to workers:
Screenshot 2022-02-17 at 19 11 31

@Aprillion Aprillion added the bug Something isn't working label Feb 17, 2022
@Aprillion
Copy link
Contributor Author

FTR: Original discussion started in https://discord.com/channels/770287896669978684/943924040962306098

@Aprillion
Copy link
Contributor Author

Aprillion commented Feb 20, 2022

Actually, I found the CF workers' version of fetch has more differences from the spec => cloudflare/cloudflare-docs#3578 to track documentation of expected differences.

Once that is documented, we could add a note to https://github.com/remix-run/remix/blob/dev/packages/create-remix/templates/cloudflare-workers/README.md to improve the developers' expectation when working with this particular deployment target.. (though, not sure how fetch behaves for other targets 🤔)

And if those differences get fixed in CF, we could even close this issue 😅

@machour
Copy link
Collaborator

machour commented Apr 26, 2023

@Aprillion Hey ! More than a year passed since you opened that issue, do you know if it's still applicable today? 🙏🏼

@Aprillion
Copy link
Contributor Author

no idea, once I stopped using the then-unsupported fetch options, I never had a use case to use those again

@machour
Copy link
Collaborator

machour commented Apr 27, 2023

Fair enough :)
I'm closing this for now, someone will eventually open a new issue if this is still a problem, thanks!

@machour machour closed this as completed Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants