It does not ignore unsupported directives anymore

[angrybacon]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and discussions and couldn’t find anything (or linked relevant results below)

Affected package

remark-directive@4.0.0

Steps to reproduce

https://stackblitz.com/edit/github-yvam2q1r

Actual behavior

I just upgraded from 3.0.1 to 4.0.0 and it seems remark-directive no longer ignores unsupported directives. In the provided sandbox, 1:3 is supposed to read as a 1-3 ratio and not a :3 directive. Is this expected?

Expected behavior

I have a number of Markdown content where : can use used with a character directly to its right (like the ratio example in the sandbox). Escaping the : with : doesn't seem very practical. Before with 3.0.1, unsupported directives ie. not provided in my <Markdown components={...} /> were simply ignored and rendered as text.

Is this a case of 1172 or an actual regression?

Runtime

No response

Package manager

No response

Operating system

No response

Build and bundle tools

No response

[JounQin]

Because they are valid directive after the new major version. That's why a major release made for.

[github-actions]

Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.

[JounQin]

Duplicate of micromark/micromark-extension-directive#29

[angrybacon]

Thank you for the link to the previous issue, it did not come up in my search prior to posting this

Because they are valid directive after the new major version

Good to know thanks. It was not obvious to me when I read the changelog 3.0.1...4.0.0 nor the documentation that changed in the same period

Since apparently that's considered normal behavior, what is the recommended way to skip legitimate usage of the colon character? Where writing 19:20 is considered a legitimate syntax for the time and where 19 :20 implies using the 20 directive

[wooorm]

In markdown, like in many other languages, you can escape things: :directive, \:not-directive.

Given that these two issues are about directive names starting with numbers, which indeed seems quite common, we could also discuss in a new issue in micromark-extension-directive, whether that should be prohibited.

[angrybacon]

Prohibited might be a bit extreme 🤔 could that be configured? A boolean where you can opt-in to be less strict about what is picked up. Note that I'm not too familiar with the whole stack so I'm discussing this here but this could very well be discussed elsewhere ie. the Microremark package that you mentioned

From a user perspective (read: from my perspective) it doesn't seem like a convenient (default) behavior to have to start worrying about how my writers should write the time. I can't exactly ask that they start escaping all : for instance 😅

[wooorm]

On “Configuration”: the point of directives is that they are all the same across tools, so, no configuration.

On users: the idea of directives is that users are aware of them: you do need to teach authors how to write things. Authors should also know how to write HTML or JSX or XML. Directives are the same.