Update to 50.23 and implement Brigad OAuth Databricks Driver Changes #40
Conversation
Co-authored-by: Stefani <>
* fix: bad aliasing * feat: added unity capabilities to metabase --------- Co-authored-by: Stefani <>
* fix: bad aliasing * feat: utilities + version * chore: handle databricks V2 * chore :added ignore * remove jar * fix: respect metabase version guideline --------- Co-authored-by: Stefani <>
* fix: bad aliasing * feat: utilities + version * chore: handle databricks V2 * chore :added ignore * remove jar * fix: respect metabase version guideline * fix: class naming and loading for name clashes --------- Co-authored-by: Stefani <>
* fix: pr comms * fix: jar naming --------- Co-authored-by: Stefani <>
* fix: bad aliasing * fix: redme updated --------- Co-authored-by: Stefani <>
As described in https://docs.oracle.com/en/java/javase/17/docs/api/java.sql/java/sql/Driver.html#connect(java.lang.String,java.util.Properties), when connect is called on a driver, it should return nil if it realizes it is the wrong kind of driver to connect to the given URL. With this change, when this happens, nil is passed on to the driver manager so that it can try other drivers.
AlexVialaBellander
changed the title
|
is it possible to optimise the usage of sql serverless warehouses to do not perform |
|
Oh just realized this PR was up for 3 weeks ! |
| :right-join true | ||
| :left-join true | ||
| :inner-join true | ||
| :window-functions/offset true}] |
There was a problem hiding this comment.
| :window-functions/offset true}] | |
| :window-functions/offset false}] |
metabase/metabase#40991 -> There is some work to be done on the driver to enable window functions I think
There was a problem hiding this comment.
I got offset to work in this build. But maybe there are edgecases?
There was a problem hiding this comment.
i didnt test, but seems that there is some work to be done to make it work on the window function side (at least for sparksql driver on the main repo)
If it works thats for the best then !
Co-authored-by: Mike <[email protected]>
Co-authored-by: Léon Stefani <[email protected]>
Co-authored-by: Léon Stefani <[email protected]>
Co-authored-by: Léon Stefani <[email protected]>
|
main on my repo works but just bumping to 0.50.26 doesnt, see here: |
Hmm, you are right,my bad, same problem here. It works fine for |
| @@ -1,5 +1,5 @@ | |||
| #Copied from https://github.com/dacort/metabase-athena-driver/blob/d7572cd99551ea998a011f8f00a1e39c1eaa59b8/Dockerfile | |||
| ARG METABASE_VERSION=v0.46.6.2 | |||
| ARG METABASE_VERSION=v0.50.26 | |||
There was a problem hiding this comment.
yeah, thi suggestion might have been a mistake. I figured that if latest master of relferrerira built againt 0.50.26, this would as well
There was a problem hiding this comment.
Ah yes, fair assumption tbh
5 participants
This PR implements the OAuth changes implemented by shrodingers at Brigad.
So the credits are a bit complicated, but originally, this driver was developed by Fernando Goncalves and Rajesh Kumar Ravi. Their original repository is no longer around. However, github user relferreira, kindly updates it here. However, his solution
does not allow for OAuth Secrets, which was something solved by shrodingers at Brigad.
Thus, this work is a combination of two somewhat actively maintained repositories. All that I do is to merge the two solutions and update the driver to work with Metabase 0.50.23.
Best here is if we could separate the two drivers and have this become the central repo for databricks metabase.