Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use position in vardata to mark internal hooks #4549

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

use position in vardata to mark internal hooks #4549

wants to merge 11 commits into from
+140 −59

Conversation

Lendemor
Copy link
Collaborator

@Lendemor Lendemor commented Dec 17, 2024 •
edited
Loading

Fixes #4516

Keeping as draft to figure a better way to collect hooks.

masenf
masenf previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty cool tbh

@Lendemor Lendemor marked this pull request as ready for review December 18, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conflict between _get_all_hooks and _get_all_hooks_internal
2 participants
@Lendemor @masenf