Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC / chore]: Ensure yarn rw setup commands generate eslint-abiding code #11871

Open
1 of 5 tasks
Philzen opened this issue Dec 29, 2024 · 0 comments
Open
1 of 5 tasks

Comments

@Philzen
Copy link
Contributor

Philzen commented Dec 29, 2024

Motivation

All code generated by our nifty yarn rw commands should conform to our ESLint rules.

Detailed proposal

Ideas / Room for improvement:

  • Run prettier in extendJSXFile function (ideally as an option that can be passed to it)
  • Understand why extendStorybookConfiguration generates code that violates import/order rule – although it clearly applies a prettier-pass
  • (nice to have) Investigate if the merge-function can be improved in a way that keeps empty lines when merging two documents. XY-Problem is that extendStorybookConfiguration generates a .storybook/preview.* file where everything is glued together, dropping all empty lines that were present in the original files
  • (nice to have) Fix the merge function duplicating the export default if both files the same

The nice to have bullet points are probably out of scope and may be dealt with in a separate PR / issue no.

Are you interested in working on this?

  • I'm interested in working on this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant