|
| 1 | +package webapi |
| 2 | + |
| 3 | +import ( |
| 4 | + "context" |
| 5 | + "net/http" |
| 6 | + "net/http/httptest" |
| 7 | + "net/url" |
| 8 | + "strings" |
| 9 | + "testing" |
| 10 | + |
| 11 | + "github.com/go-pkgz/routegroup" |
| 12 | + "github.com/stretchr/testify/assert" |
| 13 | + "github.com/stretchr/testify/require" |
| 14 | + |
| 15 | + "github.com/umputun/tg-spam/app/rules" |
| 16 | + "github.com/umputun/tg-spam/app/webapi/mocks" |
| 17 | +) |
| 18 | + |
| 19 | +type settingsRuleSetStub struct { |
| 20 | + get rules.RuleSet |
| 21 | + updated rules.RuleSet |
| 22 | + source string |
| 23 | + err error |
| 24 | +} |
| 25 | + |
| 26 | +func (s *settingsRuleSetStub) Get(_ context.Context, _ string) (rules.RuleSet, error) { |
| 27 | + return s.get, s.err |
| 28 | +} |
| 29 | + |
| 30 | +func (s *settingsRuleSetStub) Update(_ context.Context, _, source string, rs rules.RuleSet) (rules.RuleSet, error) { |
| 31 | + s.source = source |
| 32 | + s.updated = rs |
| 33 | + return rs, s.err |
| 34 | +} |
| 35 | + |
| 36 | +func TestHTMLSettingsEditHandler_RendersForm(t *testing.T) { |
| 37 | + prov := &settingsRuleSetStub{get: rules.RuleSet{ |
| 38 | + Detection: rules.DetectionRules{MaxEmoji: 5}, |
| 39 | + OpenAI: rules.LLMRules{Model: "gpt-4o-mini"}, |
| 40 | + }} |
| 41 | + srv := &Server{Config: Config{ |
| 42 | + RuleSetProvider: prov, |
| 43 | + Settings: Settings{TenantID: "tg-spam"}, |
| 44 | + EnvPinnedKeys: map[string]bool{"detection.max_emoji": true}, |
| 45 | + }} |
| 46 | + |
| 47 | + rr := httptest.NewRecorder() |
| 48 | + srv.htmlSettingsEditHandler(rr, httptest.NewRequest(http.MethodGet, "/settings/edit", http.NoBody)) |
| 49 | + |
| 50 | + require.Equal(t, http.StatusOK, rr.Code) |
| 51 | + body := rr.Body.String() |
| 52 | + assert.Contains(t, body, `name="detection.max_emoji"`) |
| 53 | + assert.Contains(t, body, `value="5"`) |
| 54 | + assert.Contains(t, body, "env-pinned", "pinned badge shown for detection.max_emoji") |
| 55 | +} |
| 56 | + |
| 57 | +func TestSaveSettingsHandler_ValidUpdate(t *testing.T) { |
| 58 | + prov := &settingsRuleSetStub{get: rules.RuleSet{WorkspaceID: "tg-spam", Version: 3}} |
| 59 | + srv := &Server{Config: Config{RuleSetProvider: prov, Settings: Settings{TenantID: "tg-spam"}}} |
| 60 | + |
| 61 | + form := url.Values{"detection.max_emoji": {"9"}, "llm.mode": {"flagged"}, "llm.consensus": {"any"}} |
| 62 | + req := httptest.NewRequest(http.MethodPost, "/settings/save", strings.NewReader(form.Encode())) |
| 63 | + req.Header.Set("Content-Type", "application/x-www-form-urlencoded") |
| 64 | + rr := httptest.NewRecorder() |
| 65 | + |
| 66 | + srv.saveSettingsHandler(rr, req) |
| 67 | + |
| 68 | + require.Equal(t, http.StatusOK, rr.Code) |
| 69 | + assert.Equal(t, 9, prov.updated.Detection.MaxEmoji) |
| 70 | + assert.Equal(t, "flagged", prov.updated.LLM.Mode) |
| 71 | + assert.Equal(t, "web", prov.source, "update source must be 'web'") |
| 72 | + assert.Contains(t, rr.Body.String(), "Saved") |
| 73 | +} |
| 74 | + |
| 75 | +func TestSaveSettingsHandler_ValidationError(t *testing.T) { |
| 76 | + prov := &settingsRuleSetStub{get: rules.RuleSet{WorkspaceID: "tg-spam"}} |
| 77 | + srv := &Server{Config: Config{RuleSetProvider: prov, Settings: Settings{TenantID: "tg-spam"}}} |
| 78 | + |
| 79 | + form := url.Values{"detection.max_emoji": {"abc"}, "llm.mode": {"flagged"}, "llm.consensus": {"any"}} |
| 80 | + req := httptest.NewRequest(http.MethodPost, "/settings/save", strings.NewReader(form.Encode())) |
| 81 | + req.Header.Set("Content-Type", "application/x-www-form-urlencoded") |
| 82 | + rr := httptest.NewRecorder() |
| 83 | + |
| 84 | + srv.saveSettingsHandler(rr, req) |
| 85 | + |
| 86 | + assert.Equal(t, "#settings-error", rr.Header().Get("HX-Retarget")) |
| 87 | + assert.Contains(t, rr.Body.String(), "detection.max_emoji") |
| 88 | + assert.Equal(t, rules.RuleSet{}, prov.updated, "nothing persisted on validation error") |
| 89 | +} |
| 90 | + |
| 91 | +func TestSettingsEditRoute_Registered(t *testing.T) { |
| 92 | + prov := &settingsRuleSetStub{get: rules.RuleSet{}} |
| 93 | + srv := NewServer(Config{ |
| 94 | + RuleSetProvider: prov, |
| 95 | + SpamFilter: &mocks.SpamFilterMock{}, |
| 96 | + Settings: Settings{TenantID: "tg-spam"}, |
| 97 | + }) |
| 98 | + router := srv.routes(routegroup.New(http.NewServeMux())) |
| 99 | + |
| 100 | + rr := httptest.NewRecorder() |
| 101 | + router.ServeHTTP(rr, httptest.NewRequest(http.MethodGet, "/settings/edit", http.NoBody)) |
| 102 | + assert.NotEqual(t, http.StatusNotFound, rr.Code, "GET /settings/edit must be routed") |
| 103 | +} |
0 commit comments