Merge pull request #2148 from signalfx/cluster-pipeline-err

vmihailenco · web-flow · commit 60081bdd5561 · 2022-07-28T13:27:22.000+03:00
fix: additional node failures in clustered pipelined reads
diff --git a/cluster.go b/cluster.go
@@ -1210,7 +1210,7 @@ func (c *ClusterClient) pipelineReadCmds(
 			continue
 		}
 
-		if c.opt.ReadOnly && isLoadingError(err) {
+		if c.opt.ReadOnly && (isLoadingError(err) || !isRedisError(err)) {
 			node.MarkAsFailing()
 			return err
 		}

Original file line number	Diff line number	Diff line change
`@@ -1210,7 +1210,7 @@ func (c *ClusterClient) pipelineReadCmds(`
`1210`	`1210`	`continue`
`1211`	`1211`	`}`
`1212`	`1212`
`1213`		`- if c.opt.ReadOnly && isLoadingError(err) {`
	`1213`	`+ if c.opt.ReadOnly && (isLoadingError(err) \|\| !isRedisError(err)) {`
`1214`	`1214`	`node.MarkAsFailing()`
`1215`	`1215`	`return err`
`1216`	`1216`	`}`