Skip to content

Commit 0c50007

Browse files
authored
Merge pull request #1273 from theo-delaune-argus/time-nanoseconds
Store time in RFC3339Nano to keep nanoseconds
2 parents 6e98832 + fea610f commit 0c50007

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

command.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -671,7 +671,7 @@ func (cmd *StringCmd) Time() (time.Time, error) {
671671
if cmd.err != nil {
672672
return time.Time{}, cmd.err
673673
}
674-
return time.Parse(time.RFC3339, cmd.Val())
674+
return time.Parse(time.RFC3339Nano, cmd.Val())
675675
}
676676

677677
func (cmd *StringCmd) Scan(val interface{}) error {

command_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,14 +72,14 @@ var _ = Describe("Cmd", func() {
7272
})
7373

7474
It("supports time.Time", func() {
75-
tm := time.Date(2019, 01, 01, 0, 0, 0, 0, time.UTC)
75+
tm := time.Date(2019, 01, 01, 9, 45, 10, 222125, time.UTC)
7676

7777
err := client.Set("time_key", tm, 0).Err()
7878
Expect(err).NotTo(HaveOccurred())
7979

8080
s, err := client.Get("time_key").Result()
8181
Expect(err).NotTo(HaveOccurred())
82-
Expect(s).To(Equal("2019-01-01T00:00:00Z"))
82+
Expect(s).To(Equal("2019-01-01T09:45:10.000222125Z"))
8383

8484
tm2, err := client.Get("time_key").Time()
8585
Expect(err).NotTo(HaveOccurred())

internal/proto/write_buffer_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,14 @@ var _ = Describe("WriteBuffer", func() {
5555
})
5656

5757
It("should append time", func() {
58-
err := wr.WriteArgs([]interface{}{time.Unix(1414141414, 0).UTC()})
58+
tm := time.Date(2019, 01, 01, 9, 45, 10, 222125, time.UTC)
59+
err := wr.WriteArgs([]interface{}{tm})
5960
Expect(err).NotTo(HaveOccurred())
6061

6162
err = wr.Flush()
6263
Expect(err).NotTo(HaveOccurred())
6364

64-
Expect(buf.Len()).To(Equal(31))
65+
Expect(buf.Len()).To(Equal(41))
6566
})
6667

6768
It("should append marshalable args", func() {

internal/proto/writer.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ func (w *Writer) writeArg(v interface{}) error {
9393
}
9494
return w.int(0)
9595
case time.Time:
96-
return w.string(v.Format(time.RFC3339))
96+
return w.string(v.Format(time.RFC3339Nano))
9797
case encoding.BinaryMarshaler:
9898
b, err := v.MarshalBinary()
9999
if err != nil {

0 commit comments

Comments
 (0)