|
2 | 2 |
|
3 | 3 | import logging |
4 | 4 | from typing import Any |
| 5 | +from urllib.parse import parse_qsl, urlencode, urlparse, urlunparse |
5 | 6 |
|
6 | 7 | from redis.asyncio import Redis |
| 8 | +from redis.asyncio.cluster import RedisCluster |
7 | 9 |
|
8 | 10 | from agent_memory_server.config import settings |
9 | 11 |
|
10 | 12 |
|
11 | 13 | logger = logging.getLogger(__name__) |
12 | | -_redis_pool: Redis | None = None |
| 14 | +_redis_pool: Redis | RedisCluster | None = None |
| 15 | +_CLUSTER_SCHEMES = {"redis+cluster", "rediss+cluster"} |
13 | 16 |
|
14 | 17 |
|
15 | | -async def get_redis_conn(url: str = settings.redis_url, **kwargs) -> Redis: |
| 18 | +def _netloc_has_multiple_hosts(netloc: str) -> bool: |
| 19 | + host_part = netloc.rsplit("@", 1)[-1] |
| 20 | + return "," in host_part |
| 21 | + |
| 22 | + |
| 23 | +def is_redis_cluster_url(url: str) -> bool: |
| 24 | + """Return True when the URL targets a Redis Cluster deployment.""" |
| 25 | + parsed = urlparse(url) |
| 26 | + if parsed.scheme in _CLUSTER_SCHEMES: |
| 27 | + return True |
| 28 | + |
| 29 | + query = dict(parse_qsl(parsed.query, keep_blank_values=True)) |
| 30 | + if query.get("cluster", "").lower() == "true": |
| 31 | + return True |
| 32 | + |
| 33 | + return _netloc_has_multiple_hosts(parsed.netloc) |
| 34 | + |
| 35 | + |
| 36 | +def _strip_cluster_query(url: str) -> str: |
| 37 | + parsed = urlparse(url) |
| 38 | + query_items = [ |
| 39 | + (key, value) |
| 40 | + for key, value in parse_qsl(parsed.query, keep_blank_values=True) |
| 41 | + if key.lower() != "cluster" |
| 42 | + ] |
| 43 | + return urlunparse(parsed._replace(query=urlencode(query_items, doseq=True))) |
| 44 | + |
| 45 | + |
| 46 | +def redis_url_for_docket(url: str) -> str: |
| 47 | + """Normalize a Redis URL for Docket's cluster-aware URL scheme.""" |
| 48 | + if not is_redis_cluster_url(url): |
| 49 | + return url |
| 50 | + |
| 51 | + parsed = urlparse(_strip_cluster_query(url)) |
| 52 | + if parsed.scheme in _CLUSTER_SCHEMES: |
| 53 | + return urlunparse(parsed) |
| 54 | + |
| 55 | + return urlunparse(parsed._replace(scheme=f"{parsed.scheme}+cluster")) |
| 56 | + |
| 57 | + |
| 58 | +def redis_url_for_redisvl(url: str) -> str: |
| 59 | + """Normalize a Redis URL for RedisVL's cluster detection.""" |
| 60 | + if not is_redis_cluster_url(url): |
| 61 | + return url |
| 62 | + |
| 63 | + parsed = urlparse(_strip_cluster_query(url)) |
| 64 | + query_items = parse_qsl(parsed.query, keep_blank_values=True) |
| 65 | + query_items.append(("cluster", "true")) |
| 66 | + return urlunparse( |
| 67 | + parsed._replace( |
| 68 | + scheme=parsed.scheme.replace("+cluster", ""), |
| 69 | + query=urlencode(query_items, doseq=True), |
| 70 | + ) |
| 71 | + ) |
| 72 | + |
| 73 | + |
| 74 | +def redis_url_for_async_redis(url: str) -> str: |
| 75 | + """Normalize a Redis URL for redis-py's async standalone/cluster clients.""" |
| 76 | + if not is_redis_cluster_url(url): |
| 77 | + return url |
| 78 | + |
| 79 | + parsed = urlparse(_strip_cluster_query(url)) |
| 80 | + return urlunparse(parsed._replace(scheme=parsed.scheme.replace("+cluster", ""))) |
| 81 | + |
| 82 | + |
| 83 | +def docket_prefix(name: str, redis_url: str) -> str: |
| 84 | + """Return the Docket key prefix for the given deployment mode.""" |
| 85 | + if is_redis_cluster_url(redis_url): |
| 86 | + return f"{{{name}}}" |
| 87 | + return name |
| 88 | + |
| 89 | + |
| 90 | +def docket_stream_key(name: str, redis_url: str) -> str: |
| 91 | + """Return the Docket stream key with cluster-safe hashing when needed.""" |
| 92 | + return f"{docket_prefix(name, redis_url)}:stream" |
| 93 | + |
| 94 | + |
| 95 | +async def get_redis_conn( |
| 96 | + url: str = settings.redis_url, **kwargs |
| 97 | +) -> Redis | RedisCluster: |
16 | 98 | """Get a Redis connection. |
17 | 99 |
|
18 | 100 | Args: |
19 | 101 | url: Redis connection URL, or None to use settings.redis_url |
20 | | - **kwargs: Additional arguments to pass to Redis.from_url |
| 102 | + **kwargs: Additional arguments to pass to the Redis client |
21 | 103 |
|
22 | 104 | Returns: |
23 | | - A Redis client instance |
| 105 | + A Redis or RedisCluster client instance |
24 | 106 | """ |
25 | 107 | global _redis_pool |
26 | 108 |
|
27 | 109 | # Always use the existing _redis_pool if it's not None, regardless of the URL parameter |
28 | 110 | # This ensures connection reuse and prevents multiple Redis connections |
29 | 111 | if _redis_pool is None: |
30 | | - _redis_pool = Redis.from_url(url, **kwargs) |
| 112 | + normalized_url = redis_url_for_async_redis(url) |
| 113 | + if is_redis_cluster_url(url): |
| 114 | + _redis_pool = RedisCluster.from_url(normalized_url, **kwargs) |
| 115 | + else: |
| 116 | + _redis_pool = Redis.from_url(normalized_url, **kwargs) |
31 | 117 | return _redis_pool |
32 | 118 |
|
33 | 119 |
|
|
0 commit comments