Skip to content

Commit f2354ee

Browse files
committed
chore(test): revert pr-check, fix loccators
Signed-off-by: xbabalov <[email protected]>
1 parent af92383 commit f2354ee

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

.github/workflows/pr-check.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,6 @@ jobs:
149149
runs-on: ubuntu-24.04
150150
env:
151151
SKIP_INSTALLATION: true
152-
DVLPR_USERNAME: ${{ secrets.DVLPR_USERNAME }}
153-
DVLPR_PASSWORD: ${{ secrets.DVLPR_PASSWORD }}
154152
steps:
155153
- uses: actions/checkout@v4
156154
with:

tests/src/developer-sandbox.spec.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,10 +183,11 @@ test.describe.serial('Red Hat Developer Sandbox extension verification', () => {
183183
await settingsBar.resourcesTab.click();
184184
const resourcesPage = new ResourcesPage(page);
185185
playExpect(await resourcesPage.resourceCardIsVisible(resourceCardLabel)).toBeTruthy();
186-
await resourcesPage.goToCreateNewResourcePage(resourceName);
186+
const createNewSandboxButton = page.getByRole('button', { name: `Create new ${resourceName}` }); //goToCreateNewResourcePage only takes 1 argument
187+
await createNewSandboxButton.click();
187188
const createResourcePage = new CreateResourcePage(page);
188189
await createResourcePage.logIntoSandboxButton.click();
189-
const websiteDialog = createResourcePage.content.getByRole('dialog', { name: 'Open External Website' });
190+
const websiteDialog = page.getByRole('dialog', { name: 'Open External Website' });
190191
await playExpect(websiteDialog).toBeVisible();
191192
const sandboxUrl = await websiteDialog.getByLabel('Dialog Details').textContent();
192193
const cancelDialogButton = websiteDialog.getByRole('button', { name: 'Cancel' });

0 commit comments

Comments
 (0)