Skip to content

Commit afcc578

Browse files
committed
Add notes that usually create-root delay is not needed
1 parent f23875a commit afcc578

6 files changed

Lines changed: 12 additions & 6 deletions

File tree

demo/reagentdemo/intro.cljs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
(ns reagentdemo.intro
22
(:require [reagent.core :as r]
3-
[reagent.dom.client :as rdomc]
43
[reagentdemo.common :as common :refer [demo-component]]
54
[reagentdemo.syntax :as s]
65
[simpleexample.core :as simple]

demo/sitetools/core.cljs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@
1313
(declare main-content)
1414

1515
(defonce root
16-
;; Init only on use, this ns is loaded for SSR build also
16+
;; Init only on use, this ns is loaded for SSR build also,
17+
;; delay is usually not needed on regular apps.
1718
(delay (rdomc/create-root (js/document.getElementById "main-content"))))
1819

1920
(defonce config (r/atom {:body [#'main-content]

examples/material-ui/src/example/core.cljs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@
205205
:xs 6}
206206
[form]]]]])
207207

208-
(defonce root (delay (rdomc/create-root (.getElementById js/document "app"))))
208+
(defonce root (rdomc/create-root (.getElementById js/document "app")))
209209

210210
(defn ^:export ^:dev/after-load run []
211-
(rdomc/render @root [main]))
211+
(rdomc/render root [main]))

examples/shadow-dom-input/src/shadow_dom_input_demo/core.cljs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,8 @@
7878
(set! (.-innerHTML shadow-app-div) "")
7979
(.appendChild shadow-app-div shadow-element)))
8080

81-
(defonce root (delay (rdomc/create-root (.getElementById js/document "app"))))
81+
(defonce root (rdomc/create-root (.getElementById js/document "app")))
8282

8383
(defn ^:export ^:dev/after-load run []
84-
(rdomc/render @root [normal-app])
84+
(rdomc/render root [normal-app])
8585
(setup-shadow-component))

examples/simple/src/simpleexample/core.cljs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@
3232
[clock]
3333
[color-input]])
3434

35+
;; Delay create-root call until app is mounted,
36+
;; this is only because this ns is already part of the demosite build.
37+
;; Delay is not usually needed for regular apps.
3538
(defonce root (delay (rdomc/create-root (.getElementById js/document "app"))))
3639

3740
(defn ^:export run []

examples/todomvc/src/todomvc/core.cljs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,9 @@
126126
[:footer#info
127127
[:p "Double-click to edit a todo"]]]))))
128128

129+
;; Delay create-root call until app is mounted,
130+
;; this is only because this ns is already part of the demosite build.
131+
;; Delay is not usually needed for regular apps.
129132
(defonce root (delay (rdomc/create-root (.getElementById js/document "app"))))
130133

131134
(defn ^:export run []

0 commit comments

Comments
 (0)