Skip to content

Conversation

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Oct 30, 2025

This also makes the Analytics pages not show download buttons or graphs with no data.
This feels much cleaner.

Old

Screenshot 2025-10-30 at 8 12 28 AM

New

Screenshot 2025-10-30 at 8 11 46 AM

This also makes the Analytics pages not show download buttons or graphs with no data.
This feels much cleaner.
@ericholscher ericholscher requested a review from a team as a code owner October 30, 2025 07:10
@stsewd
Copy link
Member

stsewd commented Oct 30, 2025

I think we should also show this message even if there is data but the addon isn't enabled, otherwise the user won't notice that page views aren't being tracked until 30 days have passed.

@ericholscher
Copy link
Member Author

ericholscher commented Nov 3, 2025

@stsewd Not sure quite what the situation there would be, but I think this is an incremental win? Feel free to open another PR if you have another improvement.

@ericholscher ericholscher merged commit 8f1bf22 into main Nov 3, 2025
4 checks passed
@ericholscher ericholscher deleted the link-addons-analytics branch November 3, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants