Merge pull request #1082 from readthedocs/davidfischer/bugfix-niche-urls-form

Fix a bug with niche URL handling

Author: davidfischer

adserver/analyzer/utils.py

@@ -30,6 +30,7 @@ def normalize_url(url):
     Currently, this means:
     - Removing ignored query paramters
     """
+    url = url.strip()
     parts = urlparse.urlparse(url)
 
     query_params = urlparse.parse_qs(parts.query, keep_blank_values=True)

adserver/forms.py

@@ -346,7 +346,7 @@ def clean_niche_urls(self):
                     raise forms.ValidationError(
                         _("'%(url)s' is an invalid URL."), params={"url": url}
                     )
-        return data
+        return "\n".join(niche_urls)
 
     def save(self, commit=True):
         if not self.instance.targeting_parameters:

adserver/tests/test_advertiser_dashboard.py

@@ -408,7 +408,8 @@ def test_flight_update_view(self):
             "include_keywords": "python, django",
             "niche_distance": 0.5,
             "niche_urls": "\n".join([
-                "https://example.com/niche1/",
+                # Make sure comments are stripped properly
+                "https://example.com/niche1/ ",
                 "https://example.com/niche2/",
             ]),
         }