Skip to content

Hardcoded CSS Colors #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hgoel0 opened this issue Apr 12, 2025 · 3 comments
Open

Hardcoded CSS Colors #570

hgoel0 opened this issue Apr 12, 2025 · 3 comments

Comments

@hgoel0
Copy link

hgoel0 commented Apr 12, 2025

There are a number of hardcoded colors in search.css. There is a desire to make them variables to enable new types of styling and dark mode.

Am going to attempt to fork, and provide a suggested set of tweaks.

PR: #571

@flying-sheep
Copy link

flying-sheep commented Apr 22, 2025

Specifically:

  • :host > div code { color: rgb(51, 51, 51) }
  • :host div.content > div.footer { color: rgb(64, 64, 64) }
  • :host > div .results .hit .content { rgba(0, 0, 0, 0.54) }

and judging by the severity of these issues, probably more.

All this makes code tags and footer text invisible in dark mode.

@humitos
Copy link
Member

humitos commented May 26, 2025

We added a few CSS variables in https://github.com/readthedocs/addons/pull/545/files#diff-3044b3415ce12ae3bdae793bf3ee514a670d60affb9628faa36e197581a8faba

If everything goes fine, we will deploy those changes tomorrow evening (Europe). You should be able to try them once the deploy is complete.

@humitos
Copy link
Member

humitos commented Jun 3, 2025

The new pattern with extra CSS variables was deployed. Let us know if you are able to customize them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants