Addons Notification polish

[humitos]

There is definitely some better UX around notifications we can improve. Especially browsing PR builds, I keep getting the notification, and I think there should be some kind of default behavior that hides it after I've seen it 2-3 times.

[humitos]

We have some logic to don't show the notification once you close it manually at

addons/src/notification.js

Lines 375 to 389 in 3815b3a

	closeNotification(e) {
	// Avoid going back to the top of the page when closing the notification
	e.preventDefault();
	// Store the information about dismissal in the Local Storage
	// Make sure to store the timestamp, so that we have the option to maybe add a TTL on the dismissal
	this.dismissedTimestamp = Date.now();
	const dismissedObj = {
	[this.localStorageKey]: { dismissedTimestamp: this.dismissedTimestamp },
	};
	NotificationAddon.setLocalStorage(dismissedObj);
	// Avoid event propagation
	return false;
	}

That logic can be improved to stop showing it in the same domain after 2-3 times being shown, if we want to.

I personally don't find the notification bothering me, but 🤷🏼

[humitos]

However, the logic we should modify here is the triggerAutoDismissTimer to save a counter in the storage. Once that counter reaches 2-3, we can stop showing it. The code lives at

addons/src/notification.js

Lines 68 to 76 in 3815b3a

	triggerAutoDismissTimer() {
	if (!document.hidden && !this.autoDismissed) {
	clearTimeout(this.timerID);
	this.timerID = setTimeout(() => {
	this.autoDismissed = true;
	this.requestUpdate();
	}, 5000);
	}
	}

[ericholscher]

@humitos can we just remove the PR build notification now that we shipped Visual Diff? :D

[agjohnson]

The work we talked about at the offsite will likely supersede this but I'll push it off the current sprint either way.

[humitos]

The work we talked about at the offsite

This is: the notification will be integrated into the UI element displayed in the top center of the page.

[humitos]

I'm going to close this issue since this work will be done in the new UI re-design at #574. Feel free to re-open if you want to work on this issue before the new UI re-design.

[ericholscher]

I'd love to just remove the PR build notification right away, if possible.