Skip to content

Commit 1b98ce4

Browse files
authored
Flyout: collapse it when clicking outside (#323)
We broke this behavior because we overwrote these methods when working in another issue. Closes #110
1 parent 3af5bd1 commit 1b98ce4

File tree

3 files changed

+5
-14
lines changed

3 files changed

+5
-14
lines changed

dist/readthedocs-addons.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/readthedocs-addons.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/flyout.js

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -55,16 +55,6 @@ export class FlyoutElement extends LitElement {
5555
}
5656
};
5757

58-
connectedCallback() {
59-
super.connectedCallback();
60-
window.addEventListener("click", this._onOutsideClick);
61-
}
62-
63-
disconnectedCallback() {
64-
window.removeEventListener("click", this._onOutsideClick);
65-
super.disconnectedCallback();
66-
}
67-
6858
renderHeader() {
6959
library.add(faCodeBranch);
7060
const iconCodeBranch = icon(faCodeBranch, {
@@ -359,8 +349,8 @@ export class FlyoutElement extends LitElement {
359349
super.connectedCallback();
360350

361351
document.addEventListener(EVENT_READTHEDOCS_FLYOUT_SHOW, this._showFlyout);
362-
363352
document.addEventListener(EVENT_READTHEDOCS_FLYOUT_HIDE, this._hideFlyout);
353+
window.addEventListener("click", this._onOutsideClick);
364354
}
365355

366356
disconnectedCallback() {
@@ -373,6 +363,7 @@ export class FlyoutElement extends LitElement {
373363
EVENT_READTHEDOCS_FLYOUT_HIDE,
374364
this.hideFlyout,
375365
);
366+
window.removeEventListener("click", this._onOutsideClick);
376367

377368
super.disconnectedCallback();
378369
}

0 commit comments

Comments
 (0)