Skip to content
This repository was archived by the owner on May 7, 2025. It is now read-only.

getDomRangeFromRangeCfi() does not accept some CFI generated from addSelectionHighlight() function #54

@tybw

Description

@tybw

This issue is a Bug

Related issue(s) and/or pull request(s)

None

Expected Behaviour

CFI generated by reader.plugins.highlights.addSelectionHighlight() should pass the isRangeCfi() checking.

Observed behaviour

A sample CFI generated by the plugin function addSelectionHighlight() looks like /4,/64/1:433,/66/1:10 when the selection spanning across paragraphs. When the same CFI is fed into Readium's reader.getDomRangeFromRangeCfi() function, it failed the validation at cfi_interpreter.js's isRangeCfi() function.

Test file(s)

The epub file with no image downloaded from http://www.gutenberg.org/ebooks/271

Product

Readium JS and Readium JS highlight plugin.
On Linux.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions