Improve cleanup in FileManager tests

Author: lxbndr

Tests/Foundation/TestFileManager.swift

@@ -211,6 +211,129 @@ class TestFileManager : XCTestCase {
         try? fm.removeItem(atPath: tmpDir.path)
     }
 
+    func test_isReadableFile() {
+        let fm = FileManager.default
+        let path = NSTemporaryDirectory() + "test_isReadableFile\(NSUUID().uuidString)"
+        defer {
+            try? fm.removeItem(atPath: path)
+        }
+
+        do {
+            // create test file
+            XCTAssertTrue(fm.createFile(atPath: path, contents: Data()))
+
+            // test unReadable if file has no permissions
+            try fm.setAttributes([.posixPermissions : NSNumber(value: Int16(0o0000))], ofItemAtPath: path)
+#if os(Windows)
+            // Files are always readable on Windows
+            XCTAssertTrue(fm.isReadableFile(atPath: path))
+#else
+            XCTAssertFalse(fm.isReadableFile(atPath: path))
+#endif
+
+            // test readable if file has read permissions
+            try fm.setAttributes([.posixPermissions : NSNumber(value: Int16(0o0400))], ofItemAtPath: path)
+            XCTAssertTrue(fm.isReadableFile(atPath: path))
+        } catch let e {
+            XCTFail("\(e)")
+        }
+        try? fm.removeItem(atPath: path)
+    }
+
+    func test_isWritableFile() {
+        let fm = FileManager.default
+        let path = NSTemporaryDirectory() + "test_isWritableFile\(NSUUID().uuidString)"
+        defer {
+            try? fm.removeItem(atPath: path)
+        }
+
+        do {
+            // create test file
+            XCTAssertTrue(fm.createFile(atPath: path, contents: Data()))
+
+            // test unWritable if file has no permissions
+            try fm.setAttributes([.posixPermissions : NSNumber(value: Int16(0o0000))], ofItemAtPath: path)
+            XCTAssertFalse(fm.isWritableFile(atPath: path))
+
+            // test writable if file has write permissions
+            try fm.setAttributes([.posixPermissions : NSNumber(value: Int16(0o0200))], ofItemAtPath: path)
+            XCTAssertTrue(fm.isWritableFile(atPath: path))
+        } catch let e {
+            XCTFail("\(e)")
+        }
+        try? fm.removeItem(atPath: path)
+    }
+
+    func test_isExecutableFile() {
+        let fm = FileManager.default
+        let path = NSTemporaryDirectory() + "test_isExecutableFile\(NSUUID().uuidString)"
+        let exePath = path + ".exe"
+        defer {
+            try? fm.removeItem(atPath: path)
+            try? fm.removeItem(atPath: exePath)
+        }
+
+        do {
+            // create test file
+            XCTAssertTrue(fm.createFile(atPath: path, contents: Data()))
+
+            // test unExecutable if file has no permissions
+            try fm.setAttributes([.posixPermissions : NSNumber(value: Int16(0o0000))], ofItemAtPath: path)
+            XCTAssertFalse(fm.isExecutableFile(atPath: path))
+
+#if os(Windows)
+            // test unExecutable even if file has an `exe` extension
+            try fm.copyItem(atPath: path, toPath: exePath)
+            XCTAssertFalse(fm.isExecutableFile(atPath: exePath))
+#else
+            // test executable if file has execute permissions
+            try fm.setAttributes([.posixPermissions : NSNumber(value: Int16(0o0100))], ofItemAtPath: path)
+            XCTAssertTrue(fm.isExecutableFile(atPath: path))
+#endif
+
+            // test against the test bundle itself
+            let testFoundationBinary = try XCTUnwrap(testBundle().path(forAuxiliaryExecutable: "TestFoundation"))
+            XCTAssertTrue(fm.isExecutableFile(atPath: testFoundationBinary))
+        } catch let e {
+            XCTFail("\(e)")
+        }
+        try? fm.removeItem(atPath: path)
+    }
+
+    func test_isDeletableFile() {
+        let fm = FileManager.default
+
+        do {
+            let dir_path = NSTemporaryDirectory() + "/test_isDeletableFile_dir/"
+            defer {
+                try? fm.removeItem(atPath: dir_path)
+            }
+            let file_path = dir_path + "test_isDeletableFile\(NSUUID().uuidString)"
+            // create test directory
+            try fm.createDirectory(atPath: dir_path, withIntermediateDirectories: true)
+            // create test file
+            XCTAssertTrue(fm.createFile(atPath: file_path, contents: Data()))
+
+            // test undeletable if parent directory has no permissions
+            try fm.setAttributes([.posixPermissions : NSNumber(value: Int16(0o0000))], ofItemAtPath: dir_path)
+            XCTAssertFalse(fm.isDeletableFile(atPath: file_path))
+
+            // test deletable if parent directory has all necessary permissions
+            try fm.setAttributes([.posixPermissions : NSNumber(value: Int16(0o0755))], ofItemAtPath: dir_path)
+            XCTAssertTrue(fm.isDeletableFile(atPath: file_path))
+
+            try? fm.removeItem(atPath: dir_path)
+        }
+        catch { XCTFail("\(error)") }
+
+        // test against known undeletable file
+#if os(Windows)
+        XCTAssertFalse(fm.isDeletableFile(atPath: "NUL"))
+#else
+        XCTAssertFalse(fm.isDeletableFile(atPath: "/dev/null"))
+#endif
+    }
+
     func test_fileAttributes() throws {
         let fm = FileManager.default
         let path = NSTemporaryDirectory() + "test_fileAttributes\(NSUUID().uuidString)"
@@ -435,6 +558,7 @@ class TestFileManager : XCTestCase {
         } else {
             XCTFail()
         }
+        try? fm.removeItem(atPath: basePath)
     }
 
     func test_directoryEnumerator() {
@@ -800,6 +924,7 @@ class TestFileManager : XCTestCase {
         } catch {
             // ignore
         }
+        cleanup()
     }
 
     func test_linkItemAtPathToPath() {