Dev: deallocate buffer in _HTTPBodyStreamSource

albertaleksieiev · albertaleksieiev · commit 4d46ec464933 · 2018-11-19T00:27:40.000+02:00
diff --git a/Foundation/URLSession/URLSessionTask.swift b/Foundation/URLSession/URLSessionTask.swift
@@ -650,7 +650,7 @@ extension _ProtocolClient: URLProtocolClient {
                     }
                 }
             }
-        default: return 
+        default: return
         }
     }
 
diff --git a/Foundation/URLSession/http/HTTPBodySource.swift b/Foundation/URLSession/http/HTTPBodySource.swift
@@ -126,6 +126,7 @@ extension _HTTPBodyStreamSource: _HTTPBodySource {
         if inputStream.hasBytesAvailable {
             let buffer = UnsafeMutableRawBufferPointer.allocate(count: length)
             guard let pointer = buffer.baseAddress?.assumingMemoryBound(to: UInt8.self) else {
+                buffer.deallocate()
                 return .error
             }
             let readBytes = self.inputStream.read(pointer, maxLength: length)

Original file line number	Diff line number	Diff line change
`@@ -650,7 +650,7 @@ extension _ProtocolClient: URLProtocolClient {`
`650`	`650`	`}`
`651`	`651`	`}`
`652`	`652`	`}`
`653`		`- default: return`
	`653`	`+ default: return`
`654`	`654`	`}`
`655`	`655`	`}`
`656`	`656`
Original file line number	Diff line number	Diff line change
`@@ -126,6 +126,7 @@ extension _HTTPBodyStreamSource: _HTTPBodySource {`
`126`	`126`	`if inputStream.hasBytesAvailable {`
`127`	`127`	`let buffer = UnsafeMutableRawBufferPointer.allocate(count: length)`
`128`	`128`	`guard let pointer = buffer.baseAddress?.assumingMemoryBound(to: UInt8.self) else {`
	`129`	`+ buffer.deallocate()`
`129`	`130`	`return .error`
`130`	`131`	`}`
`131`	`132`	`let readBytes = self.inputStream.read(pointer, maxLength: length)`