Skip to content

Commit 3201fe4

Browse files
committed
remove obsolete logic
1 parent 7041e85 commit 3201fe4

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

src/reactpy_router/components.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,6 @@ def _link(attributes: dict[str, Any], *children: Any) -> VdomDict:
4949
set_location = _use_route_state().set_location
5050
if "className" in attributes:
5151
class_name = " ".join([attributes.pop("className"), class_name])
52-
if "class_name" in attributes: # pragma: no cover
53-
# TODO: This can be removed when ReactPy stops supporting underscores in attribute names
54-
class_name = " ".join([attributes.pop("class_name"), class_name])
5552
if "href" in attributes and "to" not in attributes:
5653
attributes["to"] = attributes.pop("href")
5754
if "to" not in attributes: # pragma: no cover

src/reactpy_router/hooks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ def use_params() -> dict[str, Any]:
3838
A dictionary of the current URL's parameters.
3939
"""
4040

41-
# TODO: Check if this returns all parent params
4241
return _use_route_state().params
4342

4443

@@ -64,6 +63,7 @@ def use_search_params(
6463
# TODO: In order to match `react-router`, this will need to return a tuple of the search params \
6564
# and a function to update them. This is currently not possible without reactpy core having a \
6665
# communication layer.
66+
# https://github.com/reactive-python/reactpy/issues/975
6767
return parse_qs(
6868
query_string,
6969
keep_blank_values=keep_blank_values,

0 commit comments

Comments
 (0)