Move debugJavaScript to IHermes, remove unused dumpBasicBlockProfileTrace#53473
Closed
lavenzg wants to merge 3 commits into
Closed
Move debugJavaScript to IHermes, remove unused dumpBasicBlockProfileTrace#53473lavenzg wants to merge 3 commits into
lavenzg wants to merge 3 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81075460 |
Collaborator
lavenzg
force-pushed
the
export-D81075460
branch
from
August 28, 2025 21:44
c94dadb to
1b83604
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81075460 |
lavenzg
force-pushed
the
export-D81075460
branch
from
September 3, 2025 23:09
1b83604 to
3756824
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81075460 |
lavenzg
force-pushed
the
export-D81075460
branch
from
September 3, 2025 23:10
3756824 to
c3dacc9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81075460 |
Summary: Expose these methods so that we can access from RN code. To minimize the change, a few methods that depend on other headers or preprocessor flags are wrapped into IHermesExtra in hermes/API/hermes.h. Reviewed By: tsaichien Differential Revision: D80740969
Summary: By default, this function returns nullptr. User can pass a preprocessor definition "-DHERMES_SH_UNIT_FN=sh_export_<unit_name>" (where <unit_name> is the name passed to shermesc when compiling the JS input), so that this function returns the function pointer, which can be passed to `evaluateSHUnit` for evaluation. Reviewed By: avp Differential Revision: D80747463
Summary: This is a cleanup of IHermesExtra: 1. Move dumpSampledTraceToProfile() and debugJavasScript() to IHermes. I'm still keeping the empty DebugFlags, since changing that requires more changes. It's also possible that we may need it in the future. 2. Remove `dumpBasicBlockProfileTrace`. Use writeBasicBlockProfileTraceToFile` if users need to dump the profile. Reviewed By: tsaichien Differential Revision: D81075460
lavenzg
force-pushed
the
export-D81075460
branch
from
September 3, 2025 23:14
c3dacc9 to
7058fa9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81075460 |
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Sep 4, 2025
Summary: X-link: react/react-native#53473 This is a cleanup of IHermesExtra: 1. Move dumpSampledTraceToProfile() and debugJavasScript() to IHermes. I'm still keeping the empty DebugFlags, since changing that requires more changes. It's also possible that we may need it in the future. 2. Remove `dumpBasicBlockProfileTrace`. Use writeBasicBlockProfileTraceToFile` if users need to dump the profile. Changelog: [Internal] Reviewed By: tsaichien Differential Revision: D81075460 fbshipit-source-id: b81005e531809cfd870fd9bdb5c0e17864ed92fb
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Sep 4, 2025
Summary: X-link: react/react-native#53473 This is a cleanup of IHermesExtra: 1. Move dumpSampledTraceToProfile() and debugJavasScript() to IHermes. I'm still keeping the empty DebugFlags, since changing that requires more changes. It's also possible that we may need it in the future. 2. Remove `dumpBasicBlockProfileTrace`. Use writeBasicBlockProfileTraceToFile` if users need to dump the profile. Changelog: [Internal] Reviewed By: tsaichien Differential Revision: D81075460 fbshipit-source-id: b81005e531809cfd870fd9bdb5c0e17864ed92fb
Contributor
|
This pull request has been merged in 8c9f366. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D81075460