Skip to content

Commit f047c9b

Browse files
rshestfacebook-github-bot
authored andcommitted
Remove props that set by default for Text component on JS side (#52905)
Summary: Pull Request resolved: #52905 Similarly to [this PR](#51225), we do it for the Text component now: we don't set any non-default value props (most prominently, the accessibility ones) before passing this to native. This saves bandwidth and potentially improves the prop parsing time, which existing Fantom benchmarks do confirm. This is implemented behind a feature flag, which is false by default (will use it to run an experiment before rolling out). **NOTE:** This implementation forks the whole text component, as suggested by rubennorte, in order to isolate the changes and with the ultimate goal of removing the old version once the experiment is concluded. ## Changelog: [Internal] - Text no longer sets any default accessibility props, which should not result in visible changes in behaviour but may affect snapshot tests. Reviewed By: rubennorte Differential Revision: D79177652 fbshipit-source-id: a39430464fd5edec953b4c91be7ef9620ebd75ac
1 parent c37f3ed commit f047c9b

5 files changed

Lines changed: 529 additions & 236 deletions

File tree

0 commit comments

Comments
 (0)