RN update breaks customAction

[BigPun86]

Since i have updated my project to react-native @v0.27.2 and simple-router@0.9.2 i get this error when i try to trigger my customAction callback

Any ideas?

[maluramichael]

Same here

[maybewaityou]

Same

[Antonides]

Same for me

[BigPun86]

fixed it by replacing

customAction(opts) {
    this.customAction(opts);
 }

with

customAction(opts) {
   this.props.customAction(opts);
 }

[Antonides]

Where do you put this code?

[BigPun86]

In the main index of this module: yourProject/node_module/react-native-simple-router/index.js @ line 238

Other option is to get the following commit/fork:

npm i -save git+https://github.com/react-native-simple-router-community/react-native-simple-router.git#8f5ef30a093ad24f77903fa54f140260f7689798

[davidLeonardi]

Otherwise just submit a PR and i'll approve it

On Thu, Jul 28, 2016 at 11:28 AM Adel Bruno Grimm notifications@github.com
wrote:

In the main index of this module:
yourProject/node_module/react-native-simple-router/index.js @ line 238

Other option is to get my fork:

npm i -save git+https://github.com/react-native-simple-router-community/react-native-simple-router.git#8f5ef30a093ad24f77903fa54f140260f7689798

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#140 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AANjAszoOB4J8GwbfnCEz6NSDkVO4EfFks5qaHYggaJpZM4I0RCo
.

[Antonides]

Doesnt work for me. Used your commit/fork. My project is react-native@0.29.2

[BigPun86]

Well my project is also running on 29.2. I will submit a PR with my newest fix in the next ten minutes

[BigPun86]

try removing the module by hand, then run npm cache clean and than install it again and start the packager.

[BigPun86]

My bad, it breaks as soon as i try to use customAction, but i fixed it, i will submit a PR

[davidLeonardi]

I can see why there was a recursive loop... @charpeni mind taking a look at this as well?
I don't have any RN projects to test this on anymore :(

[BigPun86]

i got it fixed and submitted a PR, should work now @michelantonides and @SEthX

[Antonides]

@BigPun86 Thank you very much. It works