Skip to content

Commit e43d306

Browse files
authored
fix: add diffs (#9)
* fix: add difs * docs: add special thanks section
1 parent 45739aa commit e43d306

File tree

1 file changed

+21
-12
lines changed

1 file changed

+21
-12
lines changed

README.md

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,12 @@ useThirdPartyJSC=true
4141

4242
Open AppDelegate.swift and overwrite `createJSRuntimeFactory` method:
4343

44-
```swift
44+
```diff
4545
import React
4646
import React_RCTAppDelegate
4747
import ReactAppDependencyProvider
4848
import UIKit
49-
import RCTRuntime
49+
+import RCTRuntime
5050

5151
// AppDelegate code
5252

@@ -63,19 +63,19 @@ class ReactNativeDelegate: RCTDefaultReactNativeFactoryDelegate {
6363
#endif
6464
}
6565

66-
override func createJSRuntimeFactory() -> JSRuntimeFactory {
67-
jsrt_create_jsc_factory() // Use JavaScriptCore runtime
68-
}
66+
+ override func createJSRuntimeFactory() -> JSRuntimeFactory {
67+
+ jsrt_create_jsc_factory() // Use JavaScriptCore runtime
68+
+ }
6969
}
7070
```
7171

7272
### Android
7373

7474
Open `MainApplication.java` and overwrite `getJavaScriptExecutorFactory` method:
7575

76-
```java
77-
import io.github.reactnativecommunity.javascriptcore.JSCExecutorFactory
78-
import io.github.reactnativecommunity.javascriptcore.JSCRuntimeFactory
76+
```diff
77+
+import io.github.reactnativecommunity.javascriptcore.JSCExecutorFactory
78+
+import io.github.reactnativecommunity.javascriptcore.JSCRuntimeFactory
7979

8080
class MainApplication : Application(), ReactApplication {
8181

@@ -94,12 +94,12 @@ class MainApplication : Application(), ReactApplication {
9494
override val isNewArchEnabled: Boolean = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED
9595
override val isHermesEnabled: Boolean = BuildConfig.IS_HERMES_ENABLED
9696

97-
override fun getJavaScriptExecutorFactory(): JavaScriptExecutorFactory =
98-
JSCExecutorFactory(packageName, AndroidInfoHelpers.getFriendlyDeviceName())
97+
+ override fun getJavaScriptExecutorFactory(): JavaScriptExecutorFactory =
98+
+ JSCExecutorFactory(packageName, AndroidInfoHelpers.getFriendlyDeviceName())
9999
}
100100

101-
override val reactHost: ReactHost
102-
get() = getDefaultReactHost(applicationContext, reactNativeHost, JSCRuntimeFactory())
101+
+ override val reactHost: ReactHost
102+
+ get() = getDefaultReactHost(applicationContext, reactNativeHost, JSCRuntimeFactory())
103103

104104
override fun onCreate() {
105105
super.onCreate()
@@ -116,6 +116,15 @@ class MainApplication : Application(), ReactApplication {
116116

117117
This library is maintained by [Callstack](https://callstack.com/) a Total Software Engineering Consultancy that transforms organizations and teams through transformative apps.
118118

119+
### Special Thanks
120+
121+
Special thanks to the team who worked on the initial extraction of JavaScriptCore from core react-native:
122+
123+
- [Riccardo Cipolleschi](https://github.com/cipolleschi)
124+
- [Nicola Corti](https://github.com/cortinico)
125+
- [Kudo Chien](https://github.com/Kudo)
126+
- [Oskar Kwaśniewski](https://github.com/okwasniewski)
127+
119128
## License
120129

121130
Everything inside this repository is [MIT licensed](./LICENSE).

0 commit comments

Comments
 (0)