You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
React Modal Host currently only dispatches onKeyUp. We should dispatch all key events here.
Details
I'm trying to understand if there's a reason to only dispatch key up events here. It seems we should dispatch all events. Currently, this breaks some keyboard navigation items that are important for accessibility.
Discussion points
Is there a reason this is currently only key up? Is making this change to dispatch all key events acceptable?
This discussion was converted from issue #340 on June 10, 2021 08:57.
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Introduction
React Modal Host currently only dispatches onKeyUp. We should dispatch all key events here.
Details
I'm trying to understand if there's a reason to only dispatch key up events here. It seems we should dispatch all events. Currently, this breaks some keyboard navigation items that are important for accessibility.
Discussion points
Is there a reason this is currently only key up? Is making this change to dispatch all key events acceptable?
Beta Was this translation helpful? Give feedback.
All reactions