Skip to content

Commit f0c5ea3

Browse files
authored
fix: shouldn't call onPressEnter when measuring (#32)
* fix: should not call onPressEnter when measuring * chore: add test
1 parent a68897e commit f0c5ea3

File tree

2 files changed

+26
-0
lines changed

2 files changed

+26
-0
lines changed

src/Mentions.tsx

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,14 @@ class Mentions extends React.Component<MentionsProps, MentionsState> {
211211
}
212212
};
213213

214+
public onPressEnter: React.KeyboardEventHandler<HTMLTextAreaElement> = event => {
215+
const { measuring } = this.state;
216+
const { onPressEnter } = this.props;
217+
if (!measuring && onPressEnter) {
218+
onPressEnter(event);
219+
}
220+
};
221+
214222
public onInputFocus: React.FocusEventHandler<HTMLTextAreaElement> = event => {
215223
this.onFocus(event);
216224
};
@@ -369,6 +377,7 @@ class Mentions extends React.Component<MentionsProps, MentionsState> {
369377
onChange={this.onChange}
370378
onKeyDown={this.onKeyDown}
371379
onKeyUp={this.onKeyUp}
380+
onPressEnter={this.onPressEnter}
372381
onFocus={this.onInputFocus}
373382
onBlur={this.onInputBlur}
374383
/>

tests/FullProcess.spec.jsx

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,23 @@ describe('Full Process', () => {
9898
expect(wrapper.state().measuring).toBeFalsy();
9999
});
100100

101+
it('should not call onPressEnter when measuring', () => {
102+
const onPressEnter = jest.fn();
103+
const wrapper = createMentions({ onPressEnter });
104+
105+
simulateInput(wrapper, '@');
106+
wrapper.find('textarea').simulate('keyDown', {
107+
keyCode: KeyCode.ENTER,
108+
});
109+
expect(onPressEnter).not.toHaveBeenCalled();
110+
111+
simulateInput(wrapper, 'test');
112+
wrapper.find('textarea').simulate('keyDown', {
113+
keyCode: KeyCode.ENTER,
114+
});
115+
expect(onPressEnter).toHaveBeenCalled();
116+
});
117+
101118
it('ESC', () => {
102119
const wrapper = createMentions();
103120

0 commit comments

Comments
 (0)