Skip to content

Commit 0d5ae39

Browse files
committed
test: fix test case
1 parent 33b606e commit 0d5ae39

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed

src/Preview/CloseBtn.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@ export interface CloseBtnProps {
99
export default function CloseBtn(props: CloseBtnProps) {
1010
const { prefixCls, icon, onClick } = props;
1111

12-
if (icon === false || icon === null) {
13-
return null;
14-
}
15-
1612
return (
1713
<button className={`${prefixCls}-close`} onClick={onClick}>
1814
{icon}

src/Preview/index.tsx

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -421,11 +421,13 @@ const Preview: React.FC<PreviewProps> = props => {
421421
</div>
422422

423423
{/* Close Button */}
424-
<CloseBtn
425-
prefixCls={prefixCls}
426-
icon={closeIcon === false ? closeIcon : closeIcon || icons.close}
427-
onClick={onClose}
428-
/>
424+
{closeIcon !== false && closeIcon !== null && (
425+
<CloseBtn
426+
prefixCls={prefixCls}
427+
icon={closeIcon === true ? icons.close : closeIcon || icons.close}
428+
onClick={onClose}
429+
/>
430+
)}
429431

430432
{/* Switch prev or next */}
431433
{showLeftOrRightSwitches && (

tests/preview.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -660,7 +660,7 @@ describe('Preview', () => {
660660
}),
661661
);
662662

663-
expect(container.querySelector('.rc-image-preview-close')).toBeFalsy();
663+
expect(document.querySelector('.rc-image-preview-close')).toBeFalsy();
664664
});
665665

666666
it('Customize Group preview props', () => {

0 commit comments

Comments
 (0)