Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm build warnings in CI #1197

Closed
jochenklar opened this issue Nov 19, 2024 · 2 comments · Fixed by #1203
Closed

npm build warnings in CI #1197

jochenklar opened this issue Nov 19, 2024 · 2 comments · Fixed by #1203
Assignees
@MyPyDavid
Milestone
RDMO 2.3.0

Comments

@jochenklar
Copy link
Member

I think it would be good if this warning would stop the CI:

  WARNING in ./rdmo/projects/assets/js/projects/components/helper/PendingInvitations.js 25:41-48
  export 'default' (imported as 'baseUrl') was not found in 'rdmo/core/assets/js/utils/meta' (possible exports: baseUrl, language, siteId, staticUrl

Any ideas @MyPyDavid @afuetterer ?
@MyPyDavid MyPyDavid mentioned this issue Nov 27, 2024
Merged
@MyPyDavid
Copy link
Member

MyPyDavid commented Nov 27, 2024 •
edited
Loading

Ive added some settings to the webpack.config in here #1203, it should fail at the npm build:prod because of that warning.

MyPyDavid added a commit that referenced this issue Nov 28, 2024
@MyPyDavid
build(webpack): add testing env that fails on warnings #1197
cbb50fa 
Signed-off-by: David Wallace <[email protected]>
MyPyDavid added a commit that referenced this issue Nov 29, 2024
@MyPyDavid
build(webpack): build prod fails on warnings #1197
da094ce 
Signed-off-by: David Wallace <[email protected]>
MyPyDavid added a commit that referenced this issue Dec 2, 2024
@MyPyDavid
build(webpack): build prod fails on warnings #1197
9815207 
Signed-off-by: David Wallace <[email protected]>
MyPyDavid added a commit that referenced this issue Dec 2, 2024
@MyPyDavid
build(webpack): add build:dist, fails on warnings #1197
f0572f7 
Signed-off-by: David Wallace <[email protected]>
@MyPyDavid MyPyDavid linked a pull request Dec 2, 2024 that will close this issue
1197 npm build warnings in ci #1203
Merged
@MyPyDavid
Copy link
Member

we have now build:dist that fails on non-performance warnings.

@MyPyDavid MyPyDavid added this to the RDMO 2.3.0 milestone Dec 4, 2024
@MyPyDavid MyPyDavid self-assigned this Dec 4, 2024
@MyPyDavid MyPyDavid mentioned this issue Dec 6, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MyPyDavid MyPyDavid

Labels
None yet
Projects
None yet
Milestone
RDMO 2.3.0
Development

Successfully merging a pull request may close this issue.

1197 npm build warnings in ci rdmorganiser/rdmo
2 participants
@jochenklar @MyPyDavid