Merge pull request #526 from M4xymm/RDBC-1014

RDBC-1014 - Missing getRaftUniqueRequestId method in DeleteAiAgent

Author: M4xymm

src/Documents/Operations/AI/Agents/DeleteAiAgentOperation.ts

@@ -7,6 +7,7 @@ import { ServerNode } from "../../../../Http/ServerNode.js";
 import { HttpRequestParameters } from "../../../../Primitives/Http.js";
 import { StringUtil } from "../../../../Utility/StringUtil.js";
 import { throwError } from "../../../../Exceptions/index.js";
+import { RaftIdGenerator } from "../../../../Utility/RaftIdGenerator.js";
 
 export class DeleteAiAgentOperation implements IMaintenanceOperation<AiAgentConfigurationResult> {
     private readonly _identifier: string;
@@ -57,4 +58,8 @@ class DeleteAiAgentCommand extends RavenCommand<AiAgentConfigurationResult> {
 
         return this._parseResponseDefaultAsync(bodyStream)
     }
+
+    public getRaftUniqueRequestId(): string {
+        return RaftIdGenerator.newId();
+    }
 }

test/Ported/Documents/Operations/AiAgentTest.ts

@@ -1,32 +1,36 @@
 import {
     AddOrUpdateAiAgentOperation,
+    AiConnectionString,
     IDocumentStore,
-    PutConnectionStringOperation,
-    RavenConnectionString
+    OpenAiSettings,
+    PutConnectionStringOperation
 } from "../../../../src/index.js";
 import {disposeTestDocumentStore, RavenTestContext, testContext} from "../../../Utils/TestUtil.js";
 import {assertThat, assertThrows} from "../../../Utils/AssertExtensions.js";
 import {AiAgentConfiguration} from "../../../../src/Documents/Operations/AI/Agents/config/AiAgentConfiguration.js";
 
 ((RavenTestContext.isRavenDbServerVersion("7.1") && !RavenTestContext.isPullRequest) ? describe : describe.skip)("AiAgentTest", function () {
-
     let store: IDocumentStore;
 
-    beforeEach(async function () {
-        store = await testContext.getDocumentStore();
-    });
+    beforeEach(async () => store = await testContext.getDocumentStore());
 
     afterEach(async () =>
         await disposeTestDocumentStore(store));
 
+    async function putAiConnectionString() {
+        const csName = `ai-agents-${Date.now()}`;
+        const aiConnectionString = new AiConnectionString();
+        aiConnectionString.name = csName;
+        aiConnectionString.identifier = "openai-test";
+        aiConnectionString.modelType = "Chat";
+        aiConnectionString.openAiSettings = new OpenAiSettings("test-api-key", "https://api.openai.example", "gpt-test");
+
+        await store.maintenance.send(new PutConnectionStringOperation(aiConnectionString));
+        return csName;
+    }
+
     it("canCreateAiAgent", async () => {
-        const csName = `r1-${Date.now()}`;
-        const ravenConnectionString = Object.assign(new RavenConnectionString(), {
-            database: store.database,
-            topologyDiscoveryUrls: ["http://localhost:8080"],
-            name: csName
-        });
-        await store.maintenance.send(new PutConnectionStringOperation(ravenConnectionString));
+        const csName = await putAiConnectionString();
 
         const agentConfiguration: AiAgentConfiguration = {
             name: `TestAgent-${Date.now()}`,
@@ -66,13 +70,7 @@ import {AiAgentConfiguration} from "../../../../src/Documents/Operations/AI/Agen
     });
 
     it("canUpdateAiAgent", async () => {
-        const csName = `r1-${Date.now()}`;
-        const ravenConnectionString = Object.assign(new RavenConnectionString(), {
-            database: store.database,
-            topologyDiscoveryUrls: ["http://localhost:8080"],
-            name: csName
-        });
-        await store.maintenance.send(new PutConnectionStringOperation(ravenConnectionString));
+        const csName = await putAiConnectionString();
 
         const name = `Agent-${Date.now()}`;
         const initialConfig: AiAgentConfiguration = {
@@ -101,13 +99,7 @@ import {AiAgentConfiguration} from "../../../../src/Documents/Operations/AI/Agen
     });
 
     it("canListAndDeleteAiAgent", async () => {
-        const csName = `r1-${Date.now()}`;
-        const ravenConnectionString = Object.assign(new RavenConnectionString(), {
-            database: store.database,
-            topologyDiscoveryUrls: ["http://localhost:8080"],
-            name: csName
-        });
-        await store.maintenance.send(new PutConnectionStringOperation(ravenConnectionString));
+        const csName = await putAiConnectionString();
 
         const name = `agent-${Date.now()}`;
         const config: AiAgentConfiguration = {