Stlplus headers not found in containers

[WilfS]

When using the ratpac/ratpac-two:latest-base image to create a container, if I build ratpac and try to run the rattest executable, I run into issues with missing headers like "dprintf.hpp" from the stlplus library. These headers are built and installed under ratpac/install/include/stlplus/, but this path isn't added to the ROOT_INCLUDE_PATH variable in ratpac.sh, hence why they're not found. I'm guessing stlplus is typically installed already on most systems, thus there are usually no issues except in the instance of using a minimal docker image. I found that copying the stlplus headers to ratpac/install/include/ fixed my issues. A universal fix for this issue would be to install the stlplus files in ratpac/install/include/ rather than ratpac/install/include/stlplus/.

[JamesJieranShen]

Hi @WilfS , I just ran rattest in the container with no issues -- FYI, rattest is ran inside the latest-base container as part of our CI, so it is run on every single commit. I suspect that this is an issue with the installation on your end. stlplus is a vendored dependency that is almost never found on regular OSes given its age.

It is also expected that stlplus is put under $INSTALL/include/stlplus, since headers are included like #include "stlplus/dprintf.hpp" in rat code.

Please ping me again if you are still having issues. Otherwise, feel free to close this.

[WilfS]

Hi @JamesJieranShen. Thanks for looking into this. I agree that if the headers were included like #include "stlplus/dprintf.hpp" then things should work as expected, but in files like Log.hh there is no "stlplus" before the header files in the include lines. This is the specific file that was giving me issues, although there seem to be a few others such as TrackCursor.cc. It's strange that this wouldn't be an issue in the container, though. It may well be that the issue is my end, but I did manage to fix it by changing the install location for the stlplus headers to $INSTALL/include rather than $INSTALL/include/stlplus.

[JamesJieranShen]

Hi @WilfS , but there these lines in the CMakeList should work to include these directories...?

[WilfS]

Hmm, true. So the mystery now is why it failed for me. I'll investigate and update if I find the answer. Thanks!