Photon thinning implementation doesn't make sense

[tannerbk]

Three thinning factors get set here:
https://github.com/rat-pac/ratpac-two/blob/main/src/physics/src/PhotonThinning.cc#L19-L22
(why they in different ratdb tables, I'm not sure...)
one general factor, one scintillation factor, and one Cherenkov factor.

ONLY the general factor multiplies the PMT efficiency here:
https://github.com/rat-pac/ratpac-two/blob/main/src/physics/src/GLG4PMTOpticalModel.cc#L413

BOTH the general and scintillation factors are applied to the number of scint photons here:
https://github.com/rat-pac/ratpac-two/blob/main/src/physics/src/GLG4Scint.cc#L437-L438

We take the reciprocal if the Cherenkov factor here:
https://github.com/rat-pac/ratpac-two/blob/main/src/physics/src/PhysicsList.cc#L136
and apply it here:
https://github.com/rat-pac/ratpac-two/blob/main/src/physics/src/ThinnableG4Cerenkov.cc#L87

So it appears only the Cherenkov factor is applied to the cherenkov photons.

[gmwendel]

Yikes, so effectively the general thinning factor gets applied twice on scintillation photons? Good catch. If I am understanding correctly the solution would be removing src/physics/src/GLG4Scint.cc #L437

[tannerbk]

The PMT efficiency factor needs to be scaled by the appropriate thinning factors as well.

[JamesJieranShen]

This is the original PR for adding this feature. Looks like @tannerbk was the reviewer:) https://github.com/OGgroup/rat-pac-theia/pull/42