OOM protection by fallback to managed memory. #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsbk
added
improvement
madsbk
force-pushed
the
rmm_fallback_resource
branch
from
4846b68 to
2a9a7c6
Compare
pentschev
reviewed
May 20, 2025
Member
Author
|
Thanks @pentschev, I think I have addressed all your suggestion? |
pentschev
approved these changes
May 20, 2025
Member
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement out-of-memory protection by using a RMM resource
RmmFallbackResourcebased on rapidsai/rmm#1665.The idea is to use managed memory when the RMM pool raises an OOM error.