Skip to content

Commit eea2567

Browse files
committed
Fix ScanNode.do_evaluate
1 parent 207e136 commit eea2567

File tree

1 file changed

+16
-12
lines changed
  • python/cudf_polars/cudf_polars/experimental

1 file changed

+16
-12
lines changed

python/cudf_polars/cudf_polars/experimental/io.py

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
from collections.abc import Hashable, MutableMapping
4646

4747
from cudf_polars.containers import DataFrame
48-
from cudf_polars.dsl.expr import NamedExpr
4948
from cudf_polars.dsl.ir import IRExecutionContext
5049
from cudf_polars.experimental.base import StatsCollector
5150
from cudf_polars.experimental.dispatch import LowerIRTransformer
@@ -172,9 +171,11 @@ def __init__(
172171
self.split_index = split_index
173172
self.total_splits = total_splits
174173
self._non_child_args = (
174+
schema,
175+
base_scan,
175176
split_index,
176177
total_splits,
177-
*base_scan._non_child_args,
178+
parquet_options,
178179
)
179180
self.parquet_options = parquet_options
180181
self.children = ()
@@ -186,23 +187,25 @@ def __init__(
186187
@classmethod
187188
def do_evaluate(
188189
cls,
190+
schema: Schema,
191+
base_scan: Scan,
189192
split_index: int,
190193
total_splits: int,
191-
schema: Schema,
192-
typ: str,
193-
reader_options: dict[str, Any],
194-
paths: list[str],
195-
with_columns: list[str] | None,
196-
skip_rows: int,
197-
n_rows: int,
198-
row_index: tuple[str, int] | None,
199-
include_file_paths: str | None,
200-
predicate: NamedExpr | None,
201194
parquet_options: ParquetOptions,
202195
*,
203196
context: IRExecutionContext,
204197
) -> DataFrame:
205198
"""Evaluate and return a dataframe."""
199+
# Extract parameters from base_scan
200+
typ = base_scan.typ
201+
reader_options = base_scan.reader_options
202+
cloud_options = base_scan.cloud_options
203+
paths = base_scan.paths
204+
with_columns = base_scan.with_columns
205+
row_index = base_scan.row_index
206+
include_file_paths = base_scan.include_file_paths
207+
predicate = base_scan.predicate
208+
206209
if typ not in ("parquet",): # pragma: no cover
207210
raise NotImplementedError(f"Unhandled Scan type for file splitting: {typ}")
208211

@@ -253,6 +256,7 @@ def do_evaluate(
253256
schema,
254257
typ,
255258
reader_options,
259+
cloud_options,
256260
paths,
257261
with_columns,
258262
skip_rows,

0 commit comments

Comments
 (0)