Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Revert "Disable image override for ASO" #1044

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] Revert "Disable image override for ASO" #1044

wants to merge 1 commit into from

Conversation

Danil-Grigorev
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev commented Jan 24, 2025 •
edited
Loading

Reverts #1040

Thanks to updated secrets path in clusterapi-forks, we are able to push to the correct image name: azureserviceoperator.

Nightly run with this change: https://github.com/rancher/turtles/actions/runs/12950199290

Fixes: #990

@Danil-Grigorev Danil-Grigorev requested a review from a team as a code owner January 24, 2025 13:00
@furkatgofurov7
Copy link
Contributor

LGTM pending on CI run to pass: https://github.com/rancher/turtles/actions/runs/12950199290/job/36122628285

@Danil-Grigorev Danil-Grigorev changed the title Revert "Disable image override for ASO" [WIP] Revert "Disable image override for ASO" Jan 24, 2025
@Danil-Grigorev
Copy link
Contributor Author

Seems there is some issue with ASO pod:

│ provided but not defined: -secure-metrics                                                │
│ of /manager:                                                                             │
│   -enable-leader-election                                                                │
│         Enable leader election for controller manager. Enabling this will ensure there i │
│   -kubeconfig string                                                                     │
│         Paths to a kubeconfig. Only required if out-of-cluster.                          │
│   -metrics-addr string                                                                   │
│         The address the metric endpoint binds to. (default ":8080")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salasberryfin salasberryfin salasberryfin approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Azure] ASO mirrored image is missing
3 participants
@Danil-Grigorev @furkatgofurov7 @salasberryfin