Do not bind the confirm check twice on button elements inside a form.

Closes #384.

Author: lucasmazza

src/rails.js

@@ -25,7 +25,7 @@
     linkClickSelector: 'a[data-confirm], a[data-method], a[data-remote], a[data-disable-with], a[data-disable]',
 
     // Button elements bound by jquery-ujs
-    buttonClickSelector: 'button[data-remote], button[data-confirm]',
+    buttonClickSelector: 'button[data-remote]:not(form button), button[data-confirm]:not(form button)',
 
     // Select elements bound by jquery-ujs
     inputChangeSelector: 'select[data-remote], input[data-remote], textarea[data-remote]',
@@ -356,6 +356,7 @@
 
     $document.delegate(rails.buttonClickSelector, 'click.rails', function(e) {
       var button = $(this);
+
       if (!rails.allowAction(button)) return rails.stopEverything(e);
 
       if (button.is(rails.buttonDisableSelector)) rails.disableFormElement(button);

test/public/test/data-confirm.js

@@ -223,3 +223,22 @@ asyncTest('binding to confirm:complete event of a button and returning false', 2
     start();
   }, 50);
 });
+
+asyncTest('a button inside a form only confirms once', 1, function() {
+  var confirmations = 0;
+  window.confirm = function(msg) {
+    confirmations++;
+    return true;
+  };
+
+  $('#qunit-fixture').append($('<form />').append($('<button />', {
+    'data-remote': 'true',
+    'data-confirm': 'Are you absolutely sure?',
+    text: 'Click me'
+  })));
+
+  $('form > button[data-confirm]').trigger('click');
+
+  ok(confirmations === 1, 'confirmation counter should be 1, but it was ' + confirmations);
+  start();
+});