-
Notifications
You must be signed in to change notification settings - Fork 11
Add option to generate debug world with normal terrain #133
base: master
Are you sure you want to change the base?
Conversation
|
Why not just disable |
raiguard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments, and one more thing: The logic to place the accumulator and substation needs to make sure that the entities get placed, since it is no longer guaranteed that there will be solid ground in the top-left.
scripts/debug-world.lua
Outdated
| --- @param surface LuaSurface | ||
| local function setup_surface(surface) | ||
| surface.generate_with_lab_tiles = true | ||
| surface.generate_with_lab_tiles = settings.global["ee-generate-debug-world-with-lab-tiles"].value --[[@as boolean]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If lab tiles are disabled, then the surface doesn't need to be cleared, and I would also keep the clouds turned on.
locale/en/EditorExtensions.cfg
Outdated
| ee-default-infinity-filters=Infinity filters that will be applied to your inventory when you enter the editor for the first time.\n[color=255,57,48]Change this from the main menu, otherwise it will not affect new games![/color] | ||
| ee-infinity-pipe-crafter-snapping=When you place an infinity pipe directly next to a crafter fluid input, it will automatically set its filter to provide that fluid. | ||
| ee-inventory-sync=When in cheat mode, your inventory and cursor stack will be synced between the editor and normal play. | ||
| ee-override-debug-world=Treat the debug world like the testing scenario: fill with lab tiles, enable cheat mode, and give testing items. The debug world can be accessed by control + clicking the "single player" or "new game" buttons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be updated to mention the new option.
|
that should take care of everything 🤔 why is setup_surface calling surface.clear() anyways? lab worlds already have nothing in it and the function only seems to trigger for fresh worlds which by that point can't really have anything yet anyways right? convenient shortcut to call on_surface_cleared() i suppose but it feels a little odd. |

During testing i prefer/need some normal terrain whilst i also really like how this mod automatically runs
/cheatfor me.Therefore please add an official option that toggles between lab tiles and normal terrain, this pull request does it like this:

Naturally in my local copy i've already hardcoded
surface.generate_with_lab_tilestofalse, but real support is better.