-
-
Notifications
You must be signed in to change notification settings - Fork 115
Fix: envsample #903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/develop
Are you sure you want to change the base?
Fix: envsample #903
Conversation
63ca038 to
c838cfd
Compare
📝 WalkthroughWalkthroughA single line was added to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c838cfd to
5dd75d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
api/.env.sample (1)
61-62: Fix key ordering and add missing blank line at end of file.Static analysis flags two issues:
SUPERTOKENS_API_PORTshould be declared beforeSUPERTOKENS_CONNECTION_URIper dotenv-linter conventions- File should end with a blank line
🔧 Proposed fix
# SuperTokens Connection URI - Same as API Domain for most setups # For development: http://localhost:3567 # For production: https://your-supertokens-core-domain.com +SUPERTOKENS_API_PORT=3567 SUPERTOKENS_CONNECTION_URI=http://localhost:3567 -SUPERTOKENS_API_PORT=3567 +
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
api/.env.sample
🧰 Additional context used
🪛 dotenv-linter (4.0.0)
api/.env.sample
[warning] 62-62: [EndingBlankLine] No blank line at the end of the file
(EndingBlankLine)
[warning] 62-62: [UnorderedKey] The SUPERTOKENS_API_PORT key should go before the SUPERTOKENS_CONNECTION_URI key
(UnorderedKey)
Co-authored-by: shravan || श्रvan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
api/.env.sample (1)
62-62: Reorder the SuperTokens API port variable to maintain logical grouping.The new
SUPERTOKENS_API_PORTvariable should be placed within the SuperTokens configuration section (lines 45–61) rather than at the end of the file. This maintains consistent organization and follows the dotenv-linter rule for key ordering.Move this variable to line 47 (after
SUPERTOKENS_API_KEY) to group it logically with other SuperTokens settings.Suggested placement
# SuperTokens API Key - Generate a secure random string for production SUPERTOKENS_API_KEY=NixopusSuperTokensAPIKey + +# SuperTokens API Port +SUPERTOKENS_API_PORT=3567 # SuperTokens API Domain - Where your SuperTokens core is running # For development: http://localhost:3567Then remove line 62 from the end of the file.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
api/.env.sample
🧰 Additional context used
🪛 dotenv-linter (4.0.0)
api/.env.sample
[warning] 62-62: [UnorderedKey] The SUPERTOKENS_API_PORT key should go before the SUPERTOKENS_CONNECTION_URI key
(UnorderedKey)
Issue
update .env.sample
Description
Scope of Change
Select all applicable areas impacted by this PR:
Screenshot / Video / GIF (if applicable)
Attach or embed screenshots, screen recordings, or GIFs demonstrating the feature or fix.
Related PRs (if any)
Link any related or dependent PRs across repos.
Additional Notes for Reviewers (optional)
Anything reviewers should know before testing or merging (e.g., environment variables, setup steps).
Developer Checklist
To be completed by the developer who raised the PR.
Reviewer Checklist
To be completed by the reviewer before merge.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.