Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filesize of dictionary #11

Open
DanielHeath opened this issue Sep 15, 2020 · 2 comments
Open

Filesize of dictionary #11

DanielHeath opened this issue Sep 15, 2020 · 2 comments

Comments

@DanielHeath
Copy link
Contributor

It looks like dictionary.ts stores several fields that shouldn't really be needed. Everyone who visits the page needs to download & parse it, and it's 1.1mb.

@DanielHeath
Copy link
Contributor Author

I've made a couple of commits stripping it down to 300kb or so. Old versions of the file are still in git, so if we find a use for that data in future we can always pull it back out.

@plwp
Copy link
Contributor

plwp commented Sep 15, 2020

There needs to be a map from tag id to VR for implicit VR parsing I've seen it done functionally in some of the dicom-parser examples but I don't know how robust that would be (or if it's worth introducing errors).

Even if the tags aren't used in policy they might be used in parsing the data for some cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants