Chore: adjust scripts and add typecheck step in worflow (#44)

* 🧹 chore: run biome check

* 🧹 chore: simplify biome commands in package.json

* 🧹 chore: update linting step to use check script and add typecheck step

* 🧹 chore: add TypeScript error suppression comments for onboarding roles and channels

* 🧹 chore: suppress TS errors in unused auto-role event

Author: hmd-ali

.github/workflows/test.yml

@@ -32,8 +32,11 @@ jobs:
             npm install --no-audit --no-fund
           fi
 
-      - name: Lint
-        run: npm run lint
+      - name: Lint and Format
+        run: npm run check
+
+      - name: Typecheck
+        run: npm run typecheck
 
       - name: Build
         run: npm run build:ci

package.json

@@ -15,11 +15,7 @@
     "docker:dev": "NODE_VERSION=$(cat .nvmrc | tr -d 'v') docker compose --profile dev up",
     "docker:prod": "NODE_VERSION=$(cat .nvmrc | tr -d 'v') docker compose --profile prod up -d",
     "docker:stop": "docker compose down",
-    "lint": "biome lint .",
-    "lint:fix": "biome lint --fix .",
-    "format": "biome format --write .",
-    "check": "biome check .",
-    "check:fix": "biome check --write .",
+    "check": "biome check --write .",
     "typecheck": "tsc --noEmit",
     "test": "tsx --test '**/*.test.ts'",
     "test:ci": "NODE_ENV=test node --test dist/**/*.test.js",

src/commands/moderation/repel.ts

@@ -431,7 +431,8 @@ export const repelCommand = createCommand({
 
       const timeout = await handleTimeout({
         target: target,
-        durationInMilliseconds: timeoutHours !== null ? timeoutHours * HOUR : DEFAULT_TIMEOUT_DURATION_MS,
+        durationInMilliseconds:
+          timeoutHours !== null ? timeoutHours * HOUR : DEFAULT_TIMEOUT_DURATION_MS,
       });
 
       const channels = getTextChannels(interaction);

src/commands/onboarding/index.ts

@@ -19,6 +19,7 @@ export const onboardingCommand = createCommand({
       });
       return;
     }
+    // @ts-expect-error: This command isn't used and shouldn't affect anything, onboarding roles are TBD
     const onboardingRole = guild.roles.cache.get(config.onboarding.roleId);
     if (!onboardingRole) {
       await interaction.reply({
@@ -27,6 +28,7 @@ export const onboardingCommand = createCommand({
       });
       return;
     }
+    // @ts-expect-error: This command isn't used and shouldn't affect anything, onboarding channels are TBD
     const onboardingChannel = guild.channels.cache.get(config.onboarding.channelId);
     if (!onboardingChannel || !onboardingChannel.isSendable()) {
       await interaction.reply({

src/events/auto-roles.ts

@@ -1,3 +1,4 @@
+// @ts-nocheck: This event isn't used and shouldn't affect anything, auto-roles are TBD
 import { Events } from 'discord.js';
 import { config } from '../env.js';
 import { createEvent } from '../util/events.js';

src/util/advent-scheduler.ts

@@ -1,6 +1,6 @@
+import { promises as fs } from 'node:fs';
 import { ChannelType, type Client } from 'discord.js';
 import * as cron from 'node-cron';
-import { promises as fs } from 'node:fs';
 import { config } from '../env.js';
 
 const TRACKER_FILE = config.adventOfCodeTrackerPath;