Merged
Conversation
Contributor
Author
|
I also added a fix such that |
added 6 commits
October 21, 2020 11:00
Merge remote-tracking branch 'r-lib/master' into feat/custom_host # Conflicts: # R/deps.R
Contributor
Author
|
@jimhester Any problems with this MR? Can I improve this MR somehow so it gets merged? |
Member
|
Can you please add a bullet to NEWS? It should briefly describe the change and end with |
Contributor
Author
|
@jimhester I added a bullet to NEWS but the automated checks fail because of the test |
Contributor
Author
|
@jimhester Anything else I can do? |
Member
|
|
This was referenced Sep 20, 2023
|
That was really helpful, since I could not find it in the docs. Would you mind adding it, or point me to the place where this is documented? Especially the @host.name part was what I needed on ghe to make this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #448 a feature to specify a custom host URL in the Remotes field for e.g. enterprise GitHub or GitLab instances is requested.
This pull request adds a feature to specify the host URL explicitly:
The tests added may be not complete in the sense that I was not able to test against a custom host. Maybe anyone can provide some hints for better tests?