Test that dbUnquoteIdentifer() return list(<Id>)?

[MichaelChirico]

DBItest/R/spec-sql-unquote-identifier.R

Line 23 in f19fb4d

simple_out <- dbUnquoteIdentifier(con, simple_in)

We had a mistake where dbUnquoteIdentifier(con, <SQL>) returned list(<char>) instead of list(<Id>), as documented in ?dbUnquoteIdentifier:

https://dbi.r-dbi.org/reference/dbUnquoteIdentifier.html

This caused a more obscure/hard-to-debug error a bit later in the test:

expect_identical(dbUnquoteIdentifier(con, simple_out[[1]]), simple_out)

which expects to be doing dbUnquoteIdentifier(con, <Id>) but was actually doing dbUnquoteIdentifier(con, <char>).

It looks to me like we could make the failure more informative by checking that dbUnquoteIdentifier() returned list(<Id>) up front, does that make sense?

[krlmlr]

Test failures should be as obvious as possible, so, yes, this sounds right.