Merge pull request #481 from quorumcontrol/republish-perf-2

tobowers · web-flow · commit 8ffbcb1a1bc9 · 2020-09-29T09:37:01.000+02:00
fix fifo republish queue lookup
diff --git a/signer/gossip/node.go b/signer/gossip/node.go
@@ -465,7 +465,7 @@ func (n *Node) publishCompletedRound(ctx context.Context, round *round) error {
 }
 
 func (n *Node) republishCompletedRound(ctx context.Context, round *round) error {
-	roundConfPayload, ok := n.roundRepublishCache.Peek(round) // Peek acts as FIFO based on insert above
+	roundConfPayload, ok := n.roundRepublishCache.Peek(round.height) // Peek acts as FIFO based on insert above
 	if ok {
 		n.logger.Debugf("republishing round confirmed to: %s", n.notaryGroup.ID)
 		return n.pubsub.Publish(n.notaryGroup.ID, roundConfPayload.([]byte))

Original file line number	Diff line number	Diff line change
`@@ -465,7 +465,7 @@ func (n Node) publishCompletedRound(ctx context.Context, round round) error {`
`465`	`465`	`}`
`466`	`466`
`467`	`467`	`func (n Node) republishCompletedRound(ctx context.Context, round round) error {`
`468`		`- roundConfPayload, ok := n.roundRepublishCache.Peek(round) // Peek acts as FIFO based on insert above`
	`468`	`+ roundConfPayload, ok := n.roundRepublishCache.Peek(round.height) // Peek acts as FIFO based on insert above`
`469`	`469`	`if ok {`
`470`	`470`	`n.logger.Debugf("republishing round confirmed to: %s", n.notaryGroup.ID)`
`471`	`471`	`return n.pubsub.Publish(n.notaryGroup.ID, roundConfPayload.([]byte))`