-
Notifications
You must be signed in to change notification settings - Fork 38
Links to QUnit types broken #55
Comments
Thanks for reporting this! Yeah, that is all around messed up... especially since it's going to the jQuery core API docs. Correct link should be: http://api.qunitjs.com/QUnit.assert/ |
Seems that we need to override some of the base XSL templates from grunt-jquery-content. I would be surprised if this isn't causing documentation bugs in jQuery UI, Mobile, Sizzle, etc. |
I tried to link the That would make sense if we already had an instantiation of QUnit's Assert, but it's not the case here. To quick fix this I pushed #56 to set the correct type of |
I must be misunderstanding something, because I thought this was exactly the case. That's the signature of the callback, by the time it is called QUnit.assert certainly will have been instantiated and passed to it. |
Yes, I explained it wrong here. I'm just focused on qunitjs/qunit#588 and was trying to refer to that. My bad. |
I'm not sure I understand the full import of that, but from an outsider's perspective it's not ideal to not have a link to QUnit.assert there. (The one you just removed in #56) That's an important link to be able to know what you can do with that object. |
@jzaefferer and @scottgonzalez: there's any possibility to set a custom link to custom argument types there? @jrajav: let's see if we can improve/implement it. |
Let's put a link to the relevant page or category in the description of those methods. |
Why? None of the other projects use custom types. |
There's no support for custom types. I've created jquery/grunt-jquery-content#54 for discussion around the idea. |
I created a follow-up ticket for this, to implement a better solution, #58. |
Example: The
QUnit.assert
type link in the signature ofQUnit.test( name, test )
on http://api.qunitjs.com/QUnit.test/. It leads to http://api.jquery.com/Types/#QUnit.assert but there is no documentation of that type there.The text was updated successfully, but these errors were encountered: