Fix ambiguity dispatch for Integer. Fixes https://github.com/JuliaDat… (#231)

* Fix ambiguity dispatch for Integer. Fixes JuliaData/StructTypes.jl#85

* bump Julia compat to 1.6

Author: quinnj

.github/workflows/ci.yml

@@ -15,7 +15,7 @@ jobs:
       fail-fast: false
       matrix:
         version:
-          - '1.0'
+          - '1.6'
           - '1' # automatically expands to the latest stable 1.x release of Julia
           - 'nightly'
         os:

Project.toml

@@ -13,7 +13,7 @@ UUIDs = "cf7118a7-6976-5b1a-9a39-7adc72f591a4"
 [compat]
 Parsers = "0.3, 1, 2"
 StructTypes = "1.5"
-julia = "1"
+julia = "1.6"
 
 [extras]
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

src/structs.jl

@@ -63,6 +63,8 @@ read(::NumberType, buf, pos, len, b, S::Type{Union{Bool, T}}; kw...) where {T <:
 # without this, `Real` dispatches to the above definition
 read(::NumberType, buf, pos, len, b, ::Type{Real}; kw...) =
     read(NumberType(), buf, pos, len, b, Union{Float64, Int64}; kw...)
+read(::NumberType, buf, pos, len, b, ::Type{Integer}; kw...) =
+    read(NumberType(), buf, pos, len, b, Int64; kw...)
 
 @generated function read(::Struct, buf, pos, len, b, T::Union; kw...)
     U = first(T.parameters) # Extract Union from Type

test/runtests.jl

@@ -1045,4 +1045,18 @@ x = System(duration=3600.0)
 include("gentypes.jl")
 include("stringnumber.jl")
 
+# https://github.com/JuliaData/StructTypes.jl/issues/85
+struct Struct1
+    iarr::Vector{Integer}
+end
+
+StructTypes.StructType(::Type{Struct1}) = StructTypes.Struct()
+
+s1 = Struct1([1,2,3,4,5]);
+iob = IOBuffer();
+JSON3.write(iob, s1);
+s1_json = String(take!(iob))
+s2 = JSON3.read(s1_json, Struct1)
+@test s1.iarr == s2.iarr
+
 end # @testset "JSON3"