Refactoring

Author: johnpmitsch

.github/workflows/ci.yml

@@ -0,0 +1,31 @@
+name: CI
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+
+env:
+  CARGO_TERM_COLOR: always
+
+jobs:
+  test:
+    name: Test (stable)
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: dtolnay/rust-toolchain@stable
+        with:
+          components: rustfmt, clippy
+
+      - uses: Swatinem/rust-cache@v2
+
+      - name: cargo fmt
+        run: cargo fmt --all -- --check
+
+      - name: cargo clippy
+        run: cargo clippy --all-targets -- -D warnings
+
+      - name: cargo test
+        run: cargo test --all

.gitignore

@@ -1 +1,16 @@
 /target
+
+# Environment / secrets
+.env
+.env.*
+
+# Editor / IDE
+.idea/
+.vscode/
+*.swp
+
+# OS
+.DS_Store
+
+# Logs
+*.log

Cargo.lock

@@ -5,6 +5,11 @@ edition = "2021"
 description = "Command-line interface for the Quicknode SDK"
 license = "MIT"
 repository = "https://github.com/quicknode/qn"
+homepage = "https://www.quicknode.com/docs/welcome"
+authors = ["Quicknode <support@quicknode.com>"]
+readme = "README.md"
+keywords = ["quicknode", "cli", "blockchain", "web3"]
+categories = ["command-line-utilities"]
 rust-version = "1.75"
 
 [[bin]]
@@ -25,15 +30,14 @@ serde_json = "1"
 serde_yml = "0.0.12"
 toon-format = { version = "0.5", default-features = false }
 comfy-table = { version = "7", default-features = false, features = ["tty"] }
-owo-colors = { version = "4", features = ["supports-colors"] }
-supports-color = "3"
 dialoguer = "0.11"
 toml = "0.8"
-anyhow = "1"
 thiserror = "1"
 humantime = "2"
 time = { version = "0.3", features = ["formatting", "parsing", "macros"] }
 base64 = "0.22"
+tempfile = "3"
+url = "2"
 
 [dev-dependencies]
 reqwest = { version = "0.12", default-features = false }
@@ -42,4 +46,3 @@ assert_cmd = "2"
 predicates = "3"
 insta = { version = "1", features = ["yaml"] }
 tempfile = "3"
-serial_test = "3"

Cargo.toml

@@ -30,7 +30,7 @@ error: null
 ## Installation
 
 ```sh
-git clone git@github.com:quicknode/cli.git && cd cli
+git clone git@github.com:quicknode/qn.git && cd qn
 cargo install --path .
 ```
 

README.md

@@ -6,6 +6,8 @@
 //! calling a low-cost API (chain list).
 //! Status: same as whoami minus the network round-trip.
 
+use std::io::{IsTerminal, Write};
+
 use clap::{Args as ClapArgs, Subcommand};
 use quicknode_sdk::{QuicknodeSdk, SdkFullConfig};
 
@@ -120,13 +122,14 @@ fn resolve_non_interactive(global: &GlobalArgs) -> Result<(String, KeySource), C
     )
 }
 
-/// Show the last 4 chars only.
+/// Show the last 4 chars only. Char-based slicing — never panics on multi-byte input.
 fn redact(key: &str) -> String {
-    let n = key.chars().count();
-    if n <= 4 {
+    let chars: Vec<char> = key.chars().collect();
+    if chars.len() <= 4 {
         "****".to_string()
     } else {
-        format!("****{}", &key[key.len().saturating_sub(4)..])
+        let tail: String = chars[chars.len() - 4..].iter().collect();
+        format!("****{tail}")
     }
 }
 
@@ -157,4 +160,27 @@ fn print_status(global: &GlobalArgs, source: KeySource, redacted: &str, validate
     }
 }
 
-use std::io::{IsTerminal, Write};
+#[cfg(test)]
+mod tests {
+    use super::redact;
+
+    #[test]
+    fn redact_short_keys_returns_just_stars() {
+        assert_eq!(redact(""), "****");
+        assert_eq!(redact("abcd"), "****");
+    }
+
+    #[test]
+    fn redact_ascii_shows_last_four() {
+        assert_eq!(redact("abcdefgh"), "****efgh");
+    }
+
+    #[test]
+    fn redact_multibyte_does_not_panic() {
+        // αβγδεζη — each char is 2 bytes in UTF-8. Byte-slicing the last 4
+        // bytes would land in the middle of a char and panic.
+        let out = redact("αβγδεζη");
+        assert_eq!(out.chars().count(), 8); // "****" + last 4 chars
+        assert!(out.ends_with("δεζη"));
+    }
+}